Closed Bug 1655367 Opened 4 years ago Closed 4 years ago

nsprpub/pr/src/linking/prlink.c:810:17 [-Wimplicit-int] type specifier missing, defaults to 'int'

Categories

(NSPR :: NSPR, defect, P3)

4.27
Unspecified
macOS

Tracking

(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox78 unaffected, firefox79 unaffected, firefox80 wontfix, firefox81 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- unaffected
firefox80 --- wontfix
firefox81 --- fixed

People

(Reporter: cpeterson, Assigned: KaiE)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This new -Wimplicit-int clang warning on macOS is a regression in NSPR 4.27 from bug 1652330:

nsprpub/pr/src/linking/prlink.c:810:17 [-Wimplicit-int] type specifier missing, defaults to 'int'

The declaration const name_len = strlen(name); is missing a type specifier. The type should presumably be size_t like systemPrefixLen1 and systemPrefixLen2 above it.

https://searchfox.org/mozilla-central/rev/cf561cece0ca9aeaf0202e68699836d957d0c670/nsprpub/pr/src/linking/prlink.c#810

Assignee: nobody → kaie
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:KaiE, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(kaie)

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #2)

The severity field is not set for this bug.

Setting severity S4. This code warning should be fixed, but doesn't cause any user-visible problems.

Severity: -- → S4
Flags: needinfo?(kaie)
Priority: -- → P3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: