Closed Bug 1655486 Opened 4 years ago Closed 4 years ago

Support search mode across sessions

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
5

Tracking

()

RESOLVED FIXED
83 Branch
Iteration:
83.2 - Oct 5 - Oct 18
Tracking Status
firefox83 --- fixed

People

(Reporter: mak, Assigned: adw)

References

Details

Attachments

(1 file)

When we store the typed text for a browser, we should probably also store search mode.

Use-cases:
a) I start searching in a tab, move to a different window/tab to copy something, go back and expect to still be in search mode with the appropriate engine
b) I restart the browser with a typed search, it should go restore that browser in search mode with my typed search

This seems like it could be a dupe of bug 1647899? Although the scope of this bug is wider.

let's transform this to track windows and sessions only, just in case.

Summary: Support search mode across tabs, windows and sessions → Support search mode across windows and sessions

Pointing out bug 1647899 comment 6 over here, since it could form a good basis for this work.

I think a) now works as expected, so the only remaining thing here is Session Restore.

Summary: Support search mode across windows and sessions → Support search mode across sessions

in https://bugzilla.mozilla.org/show_bug.cgi?id=1647899#c7 Drew suggested to keep storing info in the urlbar, so potentially we can just have session store interact with the urlbar modules to apply and retrieve the state.

Priority: P2 → P1
Points: --- → 3
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 82.2 - Sep 7 - Sep 20
Iteration: 82.2 - Sep 7 - Sep 20 → 83.1 - Sept 21 - Oct 4

This is a WIP that basically works, but it needs more tests and some rough edges
smoothed out.

Iteration: 83.1 - Sept 21 - Oct 4 → 83.2 - Oct 5 - Oct 18
Points: 3 → 5
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9b3560927e84 Support search mode across sessions. r=mak
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Regressions: 1670932
Regressions: 1670944
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: