Closed Bug 1655543 Opened 4 years ago Closed 4 years ago

Ui inconsistencies in various sections and buttons when an OS dark theme is used.

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Type:
defect

Tracking

(thunderbird_esr78 fixed, thunderbird84 fixed)

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed
thunderbird84 --- fixed

People

(Reporter: aleca, Assigned: Paenglab)

References

Details

Attachments

(3 files)

dark mode issues.png
(deleted), image/png
Details
1655543-calendar-dark-system-theme.patch
(deleted), patch
aleca
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review
1655543-calendar-dark-system-theme-ESR.patch
(deleted), patch
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review
Attached image dark mode issues.png (deleted) —

I found some small UI issue when the Dark theme at the OS level is used (eg. Ubuntu Adwaita Dark).

  • The minimonth and body area of the calendar are light.
  • Toolbar buttons rollover is too bright.
  • Unnecessary background gradient in the email tab header area when a message is opened in a tab (decreasing readability of buttons).
  • Inconsistent hover effect in the Today Pane buttons.

Attached a screenshots with the highlighted issues.

Blocks: tb78found

(Removing the dependency, this is just a normal bug with no real relation to 78, except that it's there for that too.)

No longer blocks: tb78found
Severity: -- → S4

This fixes the calendar issues with the white areas and the buttons in the today pane header. The other issues should be fixed by the other changes we already did.

I've never seen the gradient in the header pane.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9189504 - Flags: review?(alessandro)
Comment on attachment 9189504 [details] [diff] [review] 1655543-calendar-dark-system-theme.patch Review of attachment 9189504 [details] [diff] [review]: ----------------------------------------------------------------- Perfect, thanks for taking care of this.
Attachment #9189504 - Flags: review?(alessandro) → review+
Keywords: checkin-needed-tb
Target Milestone: --- → 85 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f85ad04ee762
Apply the dark variable values to calendar with the dark Linux system theme. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9189504 [details] [diff] [review]
1655543-calendar-dark-system-theme.patch

[Approval Request Comment]
User impact if declined: on Linux with dark system theme not fully dark calendar.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9189504 - Flags: approval-comm-beta?

[Approval Request Comment]
User impact if declined: on Linux with dark system theme not fully dark calendar.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9189712 - Flags: sec-approval?
Attachment #9189712 - Flags: sec-approval? → approval-comm-esr78?

Comment on attachment 9189504 [details] [diff] [review]
1655543-calendar-dark-system-theme.patch

[Triage Comment]
Approved for beta

Attachment #9189504 - Flags: approval-comm-beta? → approval-comm-beta+

Looks good to me in testing the 84.0b3 release candidate on Ubuntu 18.04 LTS with the Adwaita-dark theme and Thunderbird Default theme. Took a bit to apply but the white did disappear after I minimized the Tweaks app.

Comment on attachment 9189712 [details] [diff] [review]
1655543-calendar-dark-system-theme-ESR.patch

[Triage Comment]
Approved for esr78

Attachment #9189712 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: