Open
Bug 1655773
Opened 4 years ago
Updated 4 years ago
Warp: support float32 optimizations
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Core
JavaScript Engine: JIT
Tracking
()
NEW
People
(Reporter: jandem, Unassigned)
References
(Blocks 1 open bug)
Details
The MUnbox instructions the transpiler inserts for GuardIsNumber break the float32 optimization. Fixing that improves performance quite a lot on the f32 assorted tests and also lets us support the assertFloat32/MAssertFloat32 check.
Reporter | ||
Comment 1•4 years ago
|
||
I think we should leave this for now. The float32 analysis is complicated and I'm not confident about the patches I wrote for this.
I want to spend some more time on this after Warp and either simplify or remove the analysis. Maybe we can disentangle it from type analysis and make it a stand-alone optimization pass that still handles the simple (maybe just non-phi?) cases.
Assignee: jdemooij → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•