Closed Bug 1656317 Opened 4 years ago Closed 1 year ago

Implement entryAdded 'lineNumber' and 'columnNumber' parameters

Categories

(Remote Protocol :: CDP, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: impossibus, Unassigned)

References

Details

All we emit for now is lineNumber: 1

Severity: -- → S3
Priority: -- → P3
Component: CDP: Log → CDP

ni?'ing myself here for some investigation into this, see the comments in https://phabricator.services.mozilla.com/D163329

Flags: needinfo?(dschubert)

Note that columnNumber is not listed in https://chromedevtools.github.io/devtools-protocol/tot/Log/#type-LogEntry, and lineNumber is not hardcoded to 1, at least tested in remote/cdp/test/browser/log/browser_entryAdded.js.

As mentioned in https://phabricator.services.mozilla.com/D163329 the lineNumber should probably be 0-based in order to match Chrome.

Also note that in CDP we basically have two different events. Log.entryAdded is for console API and service, while Runtime.exceptionThrown is for Javascript exceptions. The latter has both the column and line number.

Julian when you tried with CDP did Log.entryAdded contain a columnNumber and the docs are just not up to date? It's strange that this is missing.

Our WebDriver BiDi implementation supports that already. As such we are not going to add this to CDP.

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(dschubert)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.