Closed Bug 1656711 Opened 4 years ago Closed 4 years ago

Support SVG blur with different x and y radius

Categories

(Core :: Graphics: WebRender, task)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: mstange, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently use WR accelerated filters for <feGaussianBlur> SVG filters if the x and y radius are equal. It seems like it shouldn't be too much work to generalize this to different x and y radii.
Bug 1637209 has a testcase that would be improved as a result.

Pretty straight forward, mostly just plumbing stuff through.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26ff1a25028d Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r=gw
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fed45fbadc26 Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r=gw
Flags: needinfo?(tnikkel)
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0da3036d0890 Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r=gw
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Regressions: 1657558
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 81 Branch → ---
Backout by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d82ac6aafd9 Backed out changeset 0da3036d0890 as requested by tnikkel on irc to test if it caused bug 1657558 or not. CLOSED TREE
Regressions: 1657964

Hi Timothy, it seems the backout helped with bug 1657558. Can you confirm?

Flags: needinfo?(tnikkel)

I still suspect the crashes were unrelated and would have gone away without the backout. So I'm going to reland the patch and see if the crashes return. But I'll wait until after the merge next week.

Flags: needinfo?(tnikkel)
Flags: needinfo?(tnikkel)
Flags: needinfo?(tnikkel)
Attachment #9167509 - Attachment description: Bug 1656711. Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r?gw → Bug 1656711. Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r=gw
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/beeed787f909 Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r=gw
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Regressions: 1705972
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: