Start running reftests with software webrender
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox81 fixed)
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: gbrown)
References
Details
Attachments
(2 files)
We're looking to ship software webrender in the near future, so want to start running reftests.
Ideally these would be the same as the "Linux 18.04 x64 WebRender debug" tests, except with the "gfx.webrender.software=true" pref added.
Unfortunately these aren't green just yet, so we might need them to be hidden to begin with, or wait until they are fully green.
Reporter | ||
Comment 1•4 years ago
|
||
Now that 1656813 has landed, these should be green.
Andrew, could you please help with getting this new test configuration added?
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
:mattwoodrow - Plain reftests only, or crashtests too? jsreftests??
Reporter | ||
Comment 3•4 years ago
|
||
Probably just plain reftests is fine for now. Thank you!
Assignee | ||
Comment 4•4 years ago
|
||
It looks like there is just one perma-fail then, dom/canvas/test/reftest/webgl-color-test.html:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b8a8c00552566a686329e3d1ab026c3d967f90f
If we can resolve that I can go ahead with this as tier 1; is that an option?
Reporter | ||
Comment 5•4 years ago
|
||
That sounds great!
I think we should just mark that test as fails-if(swgl) for now, and we can resolve it as a separate task.
Reporter | ||
Comment 6•4 years ago
|
||
Filed bug 1657771 to fix the canvas issue, will write a patch to mark it as failing.
Reporter | ||
Comment 7•4 years ago
|
||
Assignee | ||
Comment 8•4 years ago
|
||
Assignee | ||
Comment 9•4 years ago
|
||
Matt, thanks for all your help here.
One last question...
As seen here, the new reftests run alongside the original ones for the "Linux 18.04 x64 WebRender debug" test platform:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2fa9aa57ae2f8b73698dbc026b1ce6c4f848f28
What is your preference for the new group suffix:
R-sw ("software" - webrender already in test platform)
R-swr ("software webrender")
R-swgl (like in the reftest sandbox)
R-(something else)?
Comment 11•4 years ago
|
||
Comment 12•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/910fdb11c7a1
https://hg.mozilla.org/mozilla-central/rev/d4f23cd40606
Description
•