Closed Bug 1657050 Opened 4 years ago Closed 4 years ago

HTML signature from file not saved

Categories

(Thunderbird :: Account Manager, defect)

Product:
Thunderbird
Component:
Account Manager
Type:
defect

Tracking

(thunderbird_esr78 fixed, thunderbird80 fixed)

Status:
VERIFIED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed
thunderbird80 --- fixed

People

(Reporter: kris.szlesinski, Assigned: khushil324)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

1.png
(deleted), image/png
Details
Bug-1657050_html-signature-file-not-saved-0.patch
(deleted), patch
mkmelin
: review+
wsmwk
: approval-comm-beta+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review
Attached image 1.png (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.105 Safari/537.36

Steps to reproduce:

I have simply attached a new .html signature in Accout Settings pane

Actual results:

Program chose the old value (old signature)

Expected results:

When I choose a different file (with number 2)
It should stay saved in the settings.
When I close and reopen settings pane, the setting is reset to old value (without the 2)

This did not occur in 68.*

Blocks: tb78found
Component: Untriaged → Account Manager
Assignee: nobody → khushil324

I don't seem to reproduce this on trunk. Was it fixed by one of the other uplifts?

Keywords: regression

I can reproduce this. This is due to account settings not saving correctly. Will submit a patch in a while.

Attachment #9167845 - Flags: review?(mkmelin+mozilla)
Attachment #9167845 - Attachment is patch: true
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Oh I see, closing and reopening the account manager is required to reproduce.

status-thunderbird80: --- → affected
status-thunderbird_esr78: --- → affected
Comment on attachment 9167845 [details] [diff] [review] Bug-1657050_html-signature-file-not-saved-0.patch Review of attachment 9167845 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thx! r=mkmelin
Attachment #9167845 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed-tb
Target Milestone: --- → 81 Branch
Comment on attachment 9167845 [details] [diff] [review] Bug-1657050_html-signature-file-not-saved-0.patch [Approval Request Comment] Regression caused by (bug #): 1610445 User impact if declined: User will not be able to save the browse-file like preferecnes in the account settings. Testing completed (on c-c, etc.): Risk to taking this patch (and alternatives if risky): Low
Attachment #9167845 - Flags: approval-comm-esr78?
Attachment #9167845 - Flags: approval-comm-beta?
Regressed by: 1610445

Are there more issues like this one? Can you please systematically go through all the options and make sure they behave as desired. This is the third "not saved" bug regressed by bug 1610445. BTW, thanks for keeping the uplift requests in mind.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/35050d50b1e4
Fix Account Settings not saving the browse-file type of properties. r=mkmelin DONTBUILD a=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9167845 [details] [diff] [review]
Bug-1657050_html-signature-file-not-saved-0.patch

[Triage Comment]
Approved for beta

Attachment #9167845 - Flags: approval-comm-beta? → approval-comm-beta+

HTML signature from file saved in both my Comcast and Gmail accounts in my testing of the 80.0b2 release candidate on Ubuntu 18.04.4.

Comment on attachment 9167845 [details] [diff] [review]
Bug-1657050_html-signature-file-not-saved-0.patch

[Triage Comment]
Approved for esr78

Attachment #9167845 - Flags: approval-comm-esr78? → approval-comm-esr78+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: