Closed
Bug 1657088
Opened 4 years ago
Closed 4 years ago
Warp: Optimize code emitted for a simple for-of loop
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(5 files, 1 obsolete file)
There are various problems with for-of as compiled by Warp. Probably most importantly we weren't even inlining the JSOp::CallIter call to Array.prototype.[Symbol.iterator]. I think with a bit of work I could even get the scalar replacement for the iterator object working. I want to do this last to not miss some other optimizations.
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → evilpies
Blocks: WarpBuilder
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D85870
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D85871
|
|
Assignee | |
Comment 4•4 years ago
|
||
This is useful for scalar replacement / escape analysis, because otherwise
we would have to handle that case there, too.
Depends on D85872
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9167907 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D85871
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3e1d47384b4d
Do inlining for JSOp::CallIter. r=iain
https://hg.mozilla.org/integration/autoland/rev/d3c031931b96
Change MCheckIsObject to return an Object. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ca8852a5f555
Folding for MIsObject and MCheckIsObj. r=jandem
https://hg.mozilla.org/integration/autoland/rev/30945c9bef85
Optimize CheckIsObj in WarpBuilder for known objects. r=jandem
|
||
Updated•4 years ago
|
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P1
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e1d47384b4d
https://hg.mozilla.org/mozilla-central/rev/d3c031931b96
https://hg.mozilla.org/mozilla-central/rev/ca8852a5f555
https://hg.mozilla.org/mozilla-central/rev/30945c9bef85
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•