Optimise Intrinsic(PossiblyWrapped)ArrayBufferByteLength, IntrinsicPossiblyWrappedTypedArrayLength, IsPossiblyWrappedRegExpObject in CacheIR
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(5 files)
|
Bug 1657100 - Part 1: Optimise Intrinsic(PossiblyWrapped)ArrayBufferByteLength in CacheIR. r=jandem!
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
Similar to Ion the "PossiblyWrapped" intrinsics only inline the function when the object isn't actually a wrapper.
|
Assignee | |
Comment 1•4 years ago
|
||
Similar to Ion only optimise the case when the object isn't actually a wrapper.
We don't have a separate MArrayBufferByteLength MIR node, so use the same
approach as used in IonBuilder and use a fixed slot load to optimise the
call.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Similar to part 1 only optimises when called without a wrapper.
Depends on D85851
|
|
Assignee | |
Comment 3•4 years ago
|
||
The first intrinsics optimised in CacheIR were still using emitNativeCalleeGuard.
Later one we've removed this guard.
Depends on D85852
|
|
Assignee | |
Comment 4•4 years ago
|
||
Use assertions for consistency with other intrinsics which are already asserting
that the correct number of arguments with the correct types are used.
Depends on D85853
|
|
Assignee | |
Comment 5•4 years ago
|
||
Similar to part 1 and part 2 only optimises when no wrappers are used.
Depends on D85854
|
||
Updated•4 years ago
|
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e41ebfe8ad5
https://hg.mozilla.org/mozilla-central/rev/73975fd0f089
https://hg.mozilla.org/mozilla-central/rev/3d3e9624de4a
https://hg.mozilla.org/mozilla-central/rev/ac2ca7f29212
https://hg.mozilla.org/mozilla-central/rev/a4dcc976be8e
Description
•