Closed Bug 1657109 Opened 4 years ago Closed 4 years ago

6.32% raptor-tp6-twitch-firefox-cold loadtime (windows10-64-shippable-qr) regression on push 7b2f3b4b6afa10365955bbbb336587df099d7aae (Tue July 21 2020)

Categories

(GeckoView :: General, defect)

Firefox 81
defect

Tracking

(firefox81 affected)

RESOLVED DUPLICATE of bug 1654357
mozilla80
Tracking Status
firefox81 --- affected

People

(Reporter: aesanu, Unassigned)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a raptor performance regression from push 7b2f3b4b6afa10365955bbbb336587df099d7aae. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

6% raptor-tp6-twitch-firefox-cold loadtime windows10-64-shippable-qr opt webrender 1,001.18 -> 1,064.50

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(esawin)
Component: Performance → General
Product: Testing → GeckoView
Target Milestone: --- → mozilla80

Bug 1654369 merely moves a pref assignment from firefox.js to all.js to enable the feature controlled by the pref on all platforms (including GeckoView).

The reported regression is on Windows load time, which is not affected at all by the change, since the pref was set to the same value before via firefox.js on desktop.

Matt, do you know what is going on, do raptor tests not use firefox.js?

Flags: needinfo?(esawin) → needinfo?(MattN+bmo)

From looking at the graph I think bug 1654357 is more likely to blame. The regression clearly started before this landing and as Eugen said, this change shouldn't have affected desktop Firefox.

Andra, what do you think about moving the blame to one of the earlier commits where the graph first showed the increase?

Flags: needinfo?(MattN+bmo) → needinfo?(aesanu)
No longer regressed by: 1654369

Sorry for the confusion, marking this as a duplicate of Bug 1654357

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(aesanu)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.