Make `HTMLEditor::HandleDeleteSelectionInternal()` not retrieve ranges to delete via `Selection`
Categories
(Core :: DOM: Editor, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(2 files)
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
This patch moves EditorBase::ExtendSelectionForDelete() into AutoRangeArray
and make it stop modifying Selection.
The method extends anchor-focus range with nsFrameSelection and it refers
bidi information in it too. Therefore, it needs to be called before modifying
anchor-focus range of Selection. Unfortunately, this makes the code messy,
but for now, we should take this. In the future, we should make the API of
nsFrameSelection free from Selection.
Depends on D85999
|
|
Assignee | |
Comment 2•4 years ago
|
||
Now, only when deleting table cell contents, HandleDeleteSelectionInternal()
depends on Selection. However, this can be moved to HandleDeleteSelection()
because recursive callers expects Selection is collapsed by its previous job.
Depends on D86182
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9d8f213f722d
https://hg.mozilla.org/mozilla-central/rev/7941839958b6
Description
•