Closed Bug 1657610 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24902 - [Web Payment] Secure payment confirmation Blink parameters.

Categories

(Core :: DOM: Web Payments, task, P4)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24902 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24902
Details from upstream follow.

Rouslan Solomakhin <rouslan@chromium.org> wrote:

[Web Payment] Secure payment confirmation Blink parameters.

Before this patch, requesting "secure-payment-confirmation" method in
PaymentRequest API would not validate the parameters.

This patch adds the "secure-payment-confirmation" parameters to
PaymentRequest API and validates them, if the
"SecurePaymentConfirmation" feature is enabled.

After this patch, PaymentRequest API validates the secure payment
confirmation parameters.

Bug: 1110324
Change-Id: I7a4b6f9da1b3e1d7604bcd9e4733dc789f77ec4b
Reviewed-on: https://chromium-review.googlesource.com/2341163
WPT-Export-Revision: 731963c08f10ccb0bf8ba114fc4b648afebca4af

Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 14 subtests

Status Summary

Firefox

OK : 1
FAIL: 14

Chrome

OK : 1
PASS: 6
FAIL: 8

Safari

OK : 1
PASS: 3
FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/payment-request/secure-payment-confirmation.https.html
Valid payment method data does not throw exceptions.: FAIL
The timeout field is optional.: FAIL
The action field is optional.: FAIL

New Tests That Don't Pass

/payment-request/secure-payment-confirmation.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
The networkData field is required.: FAIL (Chrome: FAIL, Safari: FAIL)
Large instrumentId value throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
The fallbackUrl field is required.: FAIL (Chrome: FAIL, Safari: FAIL)
Valid payment method data does not throw exceptions.: FAIL (Chrome: PASS, Safari: PASS)
The timeout field is optional.: FAIL (Chrome: PASS, Safari: PASS)
Large fallbackUrl value throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
Empty instrumentId field throws exception.: FAIL (Chrome: FAIL, Safari: FAIL)
Empty networkData field throws exception.: FAIL (Chrome: FAIL, Safari: FAIL)
Large networkData value throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
The action field is optional.: FAIL (Chrome: PASS, Safari: PASS)
The instrumentId field is required.: FAIL (Chrome: FAIL, Safari: FAIL)
Null networkData field throws exception.: FAIL (Chrome: FAIL, Safari: FAIL)
Timeout longer than 1 hour throws exception.: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid action parameter throws an exception.: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/payment-request/secure-payment-confirmation.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/380dd64d4a16 [wpt PR 24902] - [Web Payment] Secure payment confirmation Blink parameters., a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.