Select All (Ctrl+A) in Message Source (Ctrl+U) no longer works unless I click on the text first
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird_esr78 fixed, thunderbird80 fixed, thunderbird81 fixed)
People
(Reporter: stevem, Assigned: mkmelin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
khushil324
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.105 Safari/537.36
Steps to reproduce:
This issue happened in Thunderbird 78.1.0 (64-bit), Windows 10 version 2004 build 19041.423.
I occasionally report spam e-mails I receive to SpamCop.
When I do, this is my process:
- I click on the spam e-mail entry in the folder list. (of course, this can be tested with any e-mail entry)
- Ctrl + U to see the Message Source (also can do View|Message Source in menu)
- Ctrl + A to select all the text - in previous versions of Thunderbird, this selected all the text, but it doesn't now. I have to click on the text then Ctrl+A to select all the text.
- Ctrl + C to copy the message source so I can paste that into the SpamCop entry form. (this step isn't key to this bug except to demonstrate the work flow)
Actual results:
In Step 3, I have to click on the text before doing Ctrl + A to select all the text. This disrupts the keyboard flow I had in version 68 of Ctrl+U|Ctrl+A|Ctrl-C.
Expected results:
In Step 3, I should have been able to do Ctrl+A to select all the text without having to click on the text first. In other words, the work flow should have been Ctrl+U|Ctrl+A|Ctrl+C instead of Ctrl+U|click text|Ctrl+A|Ctrl+C.
The former (Ctrl+U|Ctrl+A|Ctrl+C) is the way Thunderbird worked in version 68 before I upgraded to version 78.
Comment 1•4 years ago
|
||
Using Ctr+A to select the source without first clicking on the text is working in my TB 68.11.0 test.
Error console in 78.1.0, 80.0b1 and 81.0a1 shows:
12:40:50.415 An error occurred executing the cmd_selectAll command: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIController.doCommand]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 101" data: no] globalOverlay.js:104
goDoCommand chrome://global/content/globalOverlay.js:104
<anonymous> chrome://global/content/editMenuOverlay.js:87
Maybe the proper product and component is Toolkit:View Source?
Comment 2•4 years ago
|
||
No, we have a fork of long removed Mozilla code.
Comment 3•4 years ago
|
||
Alice, can you find the regression for us. Thanks in advance.
Comment 4•4 years ago
|
||
Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=70726ff4284b49e1e8d28626d5a0b45896c19454&tochange=ea113591641e95077f801b17482f2e6b96960389
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8acda9da4ae71f0b6561cb2021bcb370e18ce80c&tochange=a627b66768245e37b7c6f6aed7a82fb926dc8562
Suspect:
5cce0d9704abe8fa6780270445c04c3b9572b05d Dão Gottwald — Bug 1636968 - Stop focusing the view-source content window on load. r=Honza
Assignee | ||
Comment 5•4 years ago
|
||
Thanks Alice!
I guess not the largest of bugs, but since we have view source in a dedicated window and not in a tab (yet), I guess we can add back the focusing. The problems the m-c patch fixed was related to unexpected/unwanted tab selection.
Comment 6•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c36cff7af6a1
focus the content of view source on load so that selection works directly without having to click into the content. r=khushil
Comment 8•4 years ago
|
||
Comment on attachment 9168673 [details] [diff] [review]
bug1657619_viewsourcefocus.patch
[Approval Request Comment]
Regression caused by (bug #): Bug 1636968
User impact if declined: Small annoyance, user needs one more click.
Testing completed (on c-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): Low, one liner.
Comment 9•4 years ago
|
||
Comment on attachment 9168673 [details] [diff] [review]
bug1657619_viewsourcefocus.patch
[Triage Comment]
Approved for beta
Comment 10•4 years ago
|
||
bugherder uplift |
Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/fc5abff1a934
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Fixed in my testing of the 80.0b2 release candidate on Ubuntu 18.04.4.
Comment 12•4 years ago
|
||
Comment on attachment 9168673 [details] [diff] [review]
bug1657619_viewsourcefocus.patch
[Triage Comment]
Approved for esr78
Comment 13•4 years ago
|
||
bugherder uplift |
Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/80cc16eca4f7
Updated•4 years ago
|
Reporter | ||
Comment 14•4 years ago
|
||
This is fixed for me in 78.2.0. Thanks everyone!
Description
•