Closed
Bug 1657706
Opened 4 years ago
Closed 4 years ago
XPIDL compiler generates wrong dependencies for attributes
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
See https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/nsIPaper.h
That has a couple of issues:
- It uses
implicit_jscontext, but nothing forward-declaresJSContext. - It uses
Promise, but nothing forward-declaresmozilla::dom::Promise.
This happens to compile right now but it could stop to at any time.
|
Assignee | |
Comment 1•4 years ago
|
||
Turn needsJSTypes into something a bit more generic (I called it
BuiltinProductions, better names welcome), that we can add more stuff to
if needed.
This right now includes:
- Whether we have to forward-declare JSContext (for implicit_jscontext).
- Whether we have to forward-declare Promise.
- Whether we need to include Value.h (for jsval).
This should make us include js/Value.h slightly less.
|
||
Updated•4 years ago
|
Attachment #9168569 -
Attachment description: Bug 1657706 - Correctly forward-declare stuff for webidl attributes. r=nika,mccr8 → Bug 1657706 - Forward-declare JSContext in nsrootidl.idl. r=nika,mccr8
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91d8a8b29adc
Forward-declare JSContext in nsrootidl.idl. r=nika
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•