I'm tracking an issue where Conversations does lots of quickSearchs for address books and takes a long time.

In the following profile, the quickSearch function takes about 1 second, however approximately a third of that (321ms) is taken up getting the UUID of the address book.

https://share.firefox.dev/3kotBBB

This is because the UUID is formulated using the dirName each time, which in turn is obtained from prefs, which also obtain a fresh pref branch each time.

None of these are necessary, and can easily be cached. Caching these should also help speed up accessing address books more generally as well.

I have a patch for these. I've checked it eliminates the extra calls on comm-central, though I can't easily check the full patch on my profile where I had the original issue.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6df8f7aaa7b5e009ea6e12dfc79349edb88271ca

Geoff, I'd like to see this on beta soon. If Mark isn't available this week to drive it, in could you please do so? Thanks

matching severity of bug 1657565. ref bug 1657565 comment 15

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/comm-central/rev/8bb60d09ef96
Cache various values in AddrBookDirectory to avoid expensive rebuilds all the time. r=darktrojan

Comment on attachment 9168936 [details]
Bug 1658062 - Cache various values in AddrBookDirectory to avoid expensive rebuilds all the time. r?darktrojan!

[Approval Request Comment]
Regression caused by (bug #): Address book changes.
User impact if declined: Performance impact.
Testing completed (on c-c, etc.): Landed on c-c.
Risk to taking this patch (and alternatives if risky): Should be low - caches various variables in the address book to avoid re-loading them all the time.

Comment on attachment 9168936 [details]
Bug 1658062 - Cache various values in AddrBookDirectory to avoid expensive rebuilds all the time. r?darktrojan!

[Triage Comment]
Approved for beta

Thunderbird 80.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/7f53b929dfe0

Comment on attachment 9168936 [details]
Bug 1658062 - Cache various values in AddrBookDirectory to avoid expensive rebuilds all the time. r?darktrojan!

[Triage Comment]
Approved for esr78
This helped me with bug 1657565.

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/0b9a1179f1ea