Closed Bug 1658086 Opened 4 years ago Closed 4 years ago

Fix regressions caused by Bug 1604807

Categories

(Toolkit :: Form Autofill, defect, P1)

All
Unspecified
defect

Tracking

()

VERIFIED FIXED
81 Branch
Tracking Status
firefox81 --- verified

People

(Reporter: abr, Assigned: abr)

References

Details

(Whiteboard: [cc-autofill-mvp])

Attachments

(2 files)

The solution employed by Bug 1604807 appears to cause some regressions in a handful of edge cases. The solution applied by 1604807 attempted to leverage an existing codepath in the formFillController class to prevent the modifications that are caused by autofill from triggering the pop-up.

To reverse these regressions, this bug proposes to undo the fix implemented in Bug 1604807 and instead block delivery of the field update event in the javascript code.

Priority: P2 → P1
Whiteboard: [cc-autofill-mvp] → [cc-autofill-reserve]

I have manually verified that this alternate fix addresses the four bugs that identify Bug 1604807 as their regressor.

Pushed by adam@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/a2ca3a2a51fe Part 1: Revert Bug 1604807 r=zbraniecki https://hg.mozilla.org/integration/autoland/rev/01bad1cefbe7 Part 2: Block `input` event delivery when autofill is filling fields r=zbraniecki
Summary: Fix regressions cause by Bug 1604807 → Fix regressions caused by Bug 1604807
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Setting up QE+ so we remember to verify this asap.

Flags: qe-verify+
Whiteboard: [cc-autofill-reserve] → [cc-autofill-mvp]

Since all the actionable regressions were verified on QA side, marking this as verified-fixed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: