Closed Bug 1658551 Opened 4 years ago Closed 4 years ago

[rel=preload] Unused preloaded stylesheets are not reported to the web console

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- fixed

People

(Reporter: mayhemer, Assigned: emilio)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

In bug 1603542 we have added a warning about preloaded resources that are not used. Lack of automated testing seems to let slip the missing warning about css styles at the time of landing the patch, or something has changed since that time.

Set release status flags based on info from the regressing bug 1603542

Is this really a regression from bug 1603542, or is this just something that was supposed to start happening as of bug 1603542 but seems to not be happening?

(I'm not entirely clear from comment 0 what the exact nature of the problem is.)

Flags: needinfo?(honzab.moz)

(Also, are there any testcases/demos that you can link to that demonstrate the issue?)

(In reply to Daniel Holbert [:dholbert] from comment #2)

Is this really a regression from bug 1603542, or is this just something that was supposed to start happening as of bug 1603542 but seems to not be happening?

(I'm not entirely clear from comment 0 what the exact nature of the problem is.)

The latter - it was expected to work, but it doesn't.

Flags: needinfo?(honzab.moz)

Not just the one that takes a channel. This fixes the issue.

Also, as an optimization, avoid creating a timer if we're used already
or we have already one.

Drive-by, but this is what a bunch of other console messages do.

Depends on D87267

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Attachment #9170363 - Attachment description: Bug 1658551 - Properly sanitize the URI we log to the console. r=mayhemer → Bug 1658551 - Properly sanitize the URI we log to the console. r=heycam
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c03de6bc2650 Move preload usage timer creation to the common NotifyOpen implementation. r=heycam https://hg.mozilla.org/integration/autoland/rev/92a28b0098cf Properly sanitize the URI we log to the console. r=heycam
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: