Closed
Bug 1658856
Opened 4 years ago
Closed 4 years ago
Incorrect numbers in "WR OS compositor frame" profiler markers
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | unaffected |
| firefox79 | --- | unaffected |
| firefox80 | --- | unaffected |
| firefox81 | --- | wontfix |
| firefox82 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
When a video is visible, the numbers displayed in the "WR OS compositor frame" profiler markers are often wrong. Usually there are some big percentages, indicating unsigned underflow.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•4 years ago
|
||
Set release status flags based on info from the regressing bug 1653048
status-firefox79:
--- → unaffected
status-firefox80:
--- → unaffected
status-firefox-esr68:
--- → unaffected
status-firefox-esr78:
--- → unaffected
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/6d54a1050bbd
Fix overdraw and unused tile pixel computation in the profiler markers. r=mattwoodrow
|
||
Comment 5•4 years ago
|
||
Backed out for bustages on ScreenshotGrabber.h
Backout link: https://hg.mozilla.org/integration/autoland/rev/37eb71de7e8a1c16b2f222a14c9e91669ed49fbf
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313709954&repo=autoland&lineNumber=20883
|
||
Comment 6•4 years ago
|
||
Hi Matt, can you take a look at this backout?
Flags: needinfo?(matt.woodrow)
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99a98754dfe5
Fix overdraw and unused tile pixel computation in the profiler markers. r=mattwoodrow
|
||
Updated•4 years ago
|
Flags: needinfo?(mstange.moz)
Flags: needinfo?(matt.woodrow)
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
||
Comment 9•4 years ago
|
||
Profiler fixes don't seem overly important to backport. Feel free to correct me if you feel otherwise, though.
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•