Closed Bug 1658990 Opened 4 years ago Closed 4 years ago

Warp: Transpile AddAndStoreFixedSlot and AddAndStoreDynamicSlot

Categories

(Core :: JavaScript Engine: JIT, task)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This should be nice to have, I haven't completely tested this yet so no review.
It seems like for Warp the codegen implementation should be a lot easier, because we don't use TI.

  1. I think we can omit the call to EmitCheckPropertyTypes, because we shouldn't have property types.
  2. We don't need to handle changeGroup because it can only be true when the using the definite property analysis.
Attachment #9169905 - Attachment description: Bug 1658990 - Transpile AddAndStoreFixedSlot and AddAndStoreDynamicSlot. → Bug 1658990 - Transpile AddAndStoreFixedSlot and AddAndStoreDynamicSlot. r?jandem
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e32211e5a80e Transpile GuardGroup. r=jandem https://hg.mozilla.org/integration/autoland/rev/cf3eda79a72a Transpile AddAndStoreFixedSlot and AddAndStoreDynamicSlot. r=jandem
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Blocks: CacheIRTranspiler
No longer blocks: 1638111
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: