Closed Bug 1659169 Opened 4 years ago Closed 4 years ago

Show custom Return to AMO about:welcome based off attribution

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
83 Branch
Iteration:
83.2 - Oct 5 - Oct 18
Tracking Status
firefox81 --- wontfix
firefox82 --- wontfix
firefox83 --- verified
firefox84 --- verified

People

(Reporter: pdahiya, Assigned: pdahiya, NeedInfo)

References

Details

Attachments

(6 files)

Scope of this bug is to complete Return to AMO first run user journey by showing custom about:welcome page

Assignee: nobody → pdahiya
Iteration: --- → 82.1 - Aug 24 - Sep 6
Priority: -- → P1
Priority: P1 → P2
Iteration: 82.1 - Aug 24 - Sep 6 → 82.2 - Sep 7 - Sep 20
Iteration: 82.2 - Sep 7 - Sep 20 → 83.1 - Sept 21 - Oct 4
Blocks: 1468680
Priority: P2 → P1
Attached image Screenshot of RTAMO UX in Fx75.png (deleted) —
Attached file Bug 1659169 - RTAMO custom onboarding (deleted) —
Blocks: 1668429
Iteration: 83.1 - Sept 21 - Oct 4 → 83.2 - Oct 5 - Oct 18

NI Aaron for UI review of implemented RTAMO first run page in Fx 83. Click of Add Extension opens doorhanger to install extension , click of start browsing opens awesome bar. Thanks!

Flags: needinfo?(abenson)
Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f776318df3c6 RTAMO custom onboarding r=fluent-reviewers,Mardak,flod
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Depends on: 1670908
No longer blocks: multistage-aw

The patch for this bug removed a skip-if = fission annotation from browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js and added a new test (browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js) with a skip-if = fission annotation. I'm going to assume that it was a mistake (not caught by reviewers), please be more careful. If it's not a mistake, please don't add new tests that are disabled for fission when they're added, and please don't reenable tests in an unrelated patch.

(In reply to Peter Van der Beken [:peterv] from comment #10)

The patch for this bug removed a skip-if = fission annotation from browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js and added a new test (browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js) with a skip-if = fission annotation. I'm going to assume that it was a mistake (not caught by reviewers), please be more careful. If it's not a mistake, please don't add new tests that are disabled for fission when they're added, and please don't reenable tests in an unrelated patch.

yes, it was mistake. Thanks for catching! We can file a followup fix unless this is getting fixed in another patch.

Hello,

Verified the fix using the latest Nightly (84.0a1/20201022215159) and Beta (83.0b3/20201022171613) under Windows 10 Pro 64-bit with the recommended add-on uBlock Origin.

The new RTAMO UI has been properly implemented. Clicking on the “Add the Extension” button will start the extension installation process and clicking on the “Not Now” button will open the Awesome Bar for browsing. See the attached screenshots for more details.

Status: RESOLVED → VERIFIED
Attached image RTAMO Nightly.png (deleted) —
Attached image RTAMO Beta.png (deleted) —
Depends on: 1697793
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: