Show custom Return to AMO about:welcome based off attribution
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
People
(Reporter: pdahiya, Assigned: pdahiya, NeedInfo)
References
Details
Attachments
(6 files)
Scope of this bug is to complete Return to AMO first run user journey by showing custom about:welcome page
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Comment 5•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
NI Aaron for UI review of implemented RTAMO first run page in Fx 83. Click of Add Extension opens doorhanger to install extension , click of start browsing opens awesome bar. Thanks!
Comment 8•4 years ago
|
||
bugherder |
Comment 9•4 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 10•4 years ago
|
||
The patch for this bug removed a skip-if = fission
annotation from browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js and added a new test (browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js) with a skip-if = fission
annotation. I'm going to assume that it was a mistake (not caught by reviewers), please be more careful. If it's not a mistake, please don't add new tests that are disabled for fission when they're added, and please don't reenable tests in an unrelated patch.
Assignee | ||
Comment 11•4 years ago
|
||
(In reply to Peter Van der Beken [:peterv] from comment #10)
The patch for this bug removed a
skip-if = fission
annotation from browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js and added a new test (browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js) with askip-if = fission
annotation. I'm going to assume that it was a mistake (not caught by reviewers), please be more careful. If it's not a mistake, please don't add new tests that are disabled for fission when they're added, and please don't reenable tests in an unrelated patch.
yes, it was mistake. Thanks for catching! We can file a followup fix unless this is getting fixed in another patch.
Comment 12•4 years ago
|
||
Hello,
Verified the fix using the latest Nightly (84.0a1/20201022215159) and Beta (83.0b3/20201022171613) under Windows 10 Pro 64-bit with the recommended add-on uBlock Origin.
The new RTAMO UI has been properly implemented. Clicking on the “Add the Extension” button will start the extension installation process and clicking on the “Not Now” button will open the Awesome Bar for browsing. See the attached screenshots for more details.
Comment 13•4 years ago
|
||
Comment 14•4 years ago
|
||
Description
•