Closed Bug 1659219 Opened 4 years ago Closed 4 years ago

Notification that password formfill has completed for tests to continue is sent to top frame instead of child frame.

Categories

(Toolkit :: Password Manager, task, P1)

Product:
Toolkit
Component:
Password Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

Bug 1659219, send password filled notification to child iframe instead of top window, and enable tests in cross origin mode that failed due to this, r=MattN
(deleted), text/x-phabricator-request
Details

This prevents some tests from working in cross-origin mode.

Blocks: 1654437
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/621e0372d5a8 send password filled notification to child iframe instead of top window, and enable tests in cross origin mode that failed due to this, r=MattN

For reference, this enables the following tests in cross-origin mode:

toolkit/components/passwordmgr/test/mochitest/test_autofill_password-only.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_0pw.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_1pw.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_1pw_2.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_2pw_1.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_2pw_2.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_3pw_1.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_html5.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_pwevent.html
toolkit/components/passwordmgr/test/mochitest/test_basic_form_pwonly.html
toolkit/components/passwordmgr/test/mochitest/test_dismissed_doorhanger_in_shadow_DOM.html
toolkit/components/passwordmgr/test/mochitest/test_form_action_1.html
toolkit/components/passwordmgr/test/mochitest/test_form_action_2.html
toolkit/components/passwordmgr/test/mochitest/test_form_action_javascript.html
toolkit/components/passwordmgr/test/mochitest/test_formless_autofill.html
toolkit/components/passwordmgr/test/mochitest/test_formless_submit.html
toolkit/components/passwordmgr/test/mochitest/test_maxlength.html
toolkit/components/passwordmgr/test/mochitest/test_passwords_in_type_password.html
toolkit/components/passwordmgr/test/mochitest/test_prompt.html
toolkit/components/passwordmgr/test/mochitest/test_username_focus.html

Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b0888d07df69 Backed out changeset 621e0372d5a8 for mochitest failures on test_autofill_https_downgrade.html. CLOSED TREE
Severity: -- → N/A
Priority: -- → P1
Flags: needinfo?(enndeakin)
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4efee9164012 send password filled notification to child iframe instead of top window, and enable tests in cross origin mode that failed due to this, r=MattN

https://hg.mozilla.org/mozilla-central/rev/4efee9164012

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: