Closed Bug 1659293 Opened 4 years ago Closed 4 years ago

new certificate viewer shows an empty tab label for certificates without a subject common name

Categories

(Firefox :: Security, defect, P3)

Product:
Firefox
Component:
Security
Version:
79 Branch
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- wontfix
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- wontfix
firefox84 --- verified
firefox85 --- verified

People

(Reporter: u646027, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Firefox's certificate screen
(deleted), image/png
Details
Bug 1659293 - fix cert viewer for certificates without a common name, r?prathiksha
(deleted), text/x-phabricator-request
Details
Attached image Firefox's certificate screen (deleted) —

Steps to reproduce:

  1. Access website that use cross-root certificates. (e.g. https://english.president.gov.tw/)
  2. Select "🔒" → ">" → "More Infomation" → "View Certificate"

Actual results:
The rightmost button is empty.

Expected results:
Common Name is shown on the button.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Security: PSM
Product: Firefox → Core
Component: Security: PSM → Security
Product: Core → Firefox
Summary: An empty button is shown if using a cross-root certificate. → new certificate viewer shows an empty tab label for certificates without a subject common name

Ethan, do you think someone has cycles to fix this? Although the information about the remainder of the chain is still available, you have to know that the empty blob is still clickable. I guess it should fall back to displaying the OU (probably best to check with Dana or others in PSM to be sure).

Blocks: cert-viewer
Status: UNCONFIRMED → NEW
status-firefox79: --- → wontfix
status-firefox80: --- → wontfix
status-firefox81: --- → affected
status-firefox-esr68: --- → unaffected
status-firefox-esr78: --- → ?
Ever confirmed: true
Flags: needinfo?(ettseng)
OS: Unspecified → All

I believe Prathiksha is able to fix this issue.

Flags: needinfo?(ettseng) → needinfo?(prathikshaprasadsuman)
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Flags: needinfo?(prathikshaprasadsuman)

Sounds like prathiksha is on it, so P1'ing!

Severity: -- → S4
Priority: -- → P1

Leaving this open in case anyone else wants to take it. I do not have cycles to fix this issue at the moment.

Assignee: prathikshaprasadsuman → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ef89a6968026 fix cert viewer for certificates without a common name, r=prathiksha,fluent-reviewers,flod

https://hg.mozilla.org/mozilla-central/rev/ef89a6968026

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Regressions: 1673233
No longer regressions: 1673233
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1673233
Blocks: 1673325
Flags: qe-verify+

I managed to reproduce the issue using an older version of Nightly (2020-08-15) on Windows 10 x64.
I retested everything using latest Nightly 85.0a1 and Firefox 84.0b3 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 11.0.1. The issue is not reproducing anymore.

Status: RESOLVED → VERIFIED
status-firefox84: fixed → verified
status-firefox85: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: