The menu bar of the address book window contains the option "Tools | Address Book", which does nothing.

(Not a regression; I left this one UNCONFIRMED as one could argue that the option works as expected.)

STR:

1. Open address book window
2. Click on "Tools" in menu bar

Expected:
See tools that do things.

Actual:
List contains an entry "Address Book". That entry does nothing (because the address book window is already open and focused).

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=f22b7a839730467a908b1d4f2561c28bab28073c&tochange=bf7adc1ba8ee2f5494d107d8f6b8f6e6046c4661
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b2a9a4bb5c94de179ae7a3f52fde58c0e2897498&tochange=71edaf2bd1b01daffb805627623712bd329fb5f9

Yeah, makes no sense.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8e8bacd1a114
Remove the Address book menuitem in Address book window. r=mkmelin

Comment on attachment 9170226 [details] [diff] [review]
1659319-remove-addressbook-menuitem.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1442045
User impact if declined: unneeded menuitem
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

I suspect this broke OSX tests - https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedTaskRun=LaKNULJqRGObYgFLgOxTDQ.0&revision=507a1c3997e793674ac531f95f4c33b50279faf7

Here's a try with it backed out: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=67994b92dbbf7f16fa853da03433bcb78ffa60da

Fix the "unknown entity" error on Mac.

Try with my fix: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a8368d28a7c6254ea3787bf170d769887205d82c

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5d9541e4e626
Fix for Mac: load the AB menuitem only in composer. r=mkmelin

Comment on attachment 9170226 [details] [diff] [review]
1659319-remove-addressbook-menuitem.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1442045
User impact if declined: unneeded menuitem
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment on attachment 9170401 [details] [diff] [review]
1659319-mac-menu-fix.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1442045
User impact if declined: unneeded menuitem
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment on attachment 9170226 [details] [diff] [review]
1659319-remove-addressbook-menuitem.patch

[Triage Comment]
Approved for beta
Approved for esr78

Comment on attachment 9170401 [details] [diff] [review]
1659319-mac-menu-fix.patch

[Triage Comment]
Approved for beta
Approved for esr78

Thunderbird 80.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/368f5f93fe9a
https://hg.mozilla.org/releases/comm-beta/rev/b81fa04fac1c

Sh.t, I missed that the macWindowMenu.inc.xhtml is also loaded in the main window.

[Approval Request Comment]
Regression caused by (bug #): bug 1442045
User impact if declined: unneeded menuitem
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Better?

Comment on attachment 9170897 [details] [diff] [review]
1659319-mac-menu-fix2.patch.patch

Thanks, I think that is clearer than the other way.

Comment on attachment 9170897 [details] [diff] [review]
1659319-mac-menu-fix2.patch.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1442045
User impact if declined: unneeded menuitem
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ab638a0141bc
2nd fix for Mac: Main window needs the menuitem too. r=darktrojan

Removed in my test of 80.0b5 on Ubuntu 18.04.5 LTS.

(2nd mac followup - for consistency when uplifting to c-esr78)

https://hg.mozilla.org/releases/comm-beta/rev/a693c72a893d56f052dc1048050e04278eb772ee

Comment on attachment 9170897 [details] [diff] [review]
1659319-mac-menu-fix2.patch.patch

[Triage Comment]
Accepting for 78.2.0.

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/c0c80f3b0869
https://hg.mozilla.org/releases/comm-esr78/rev/1a4e42d4ed6f
https://hg.mozilla.org/releases/comm-esr78/rev/fa83c2d35aba

The Tools > Address Book item is still there in the Address Book in my testing of 78.2.0 release candidate on Ubuntu 18.04.5 LTS. New profile used.

Helps to be testing the correct build.