Closed Bug 1659335 Opened 4 years ago Closed 4 years ago

When the box 'Accept cookies from sites' is not checked, the cookies 'Exceptions' button is greyed out

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Type:
defect

Tracking

(thunderbird_esr78+ fixed, thunderbird81 affected)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 + fixed
thunderbird81 --- affected

People

(Reporter: chriechers, Assigned: lasana)

References

(Regression)

Details

(Keywords: regression, Whiteboard: smoketestb78.2.0-pre)

Attachments

(2 files, 2 obsolete files)

cookie_exceptions.png
(deleted), image/png
Details
bug1659335fixv3.patch
(deleted), patch
mkmelin
: review+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review
Attached image cookie_exceptions.png (deleted) —

TB78.2.0-pre build1 on Linux

Preferences - Privacy & Security
When the box 'Accept cookies from sites' is not checked, the cookies 'Exceptions' button is greyed out - see attached screenshot.
This isn't the case with TB68. The idea is not to allow cookies for RSS feeds, but create exceptions to allow cookies for OAuth2 providers.
The problem is also present in TB81.0 daily.

Alice, can you find the regression for us, please. Thanks in advance.

Flags: needinfo?(alice0775)

Thanks Alice. The regression isn't quite clear here, maybe bug 1622703. Or would it have been something in M-C? Unlikely since this is TB UI.

Flags: needinfo?(geoff)

Christian, can you please clarify the issue a bit. Usually one would think that if "Accept cookies from sites" is checked, it makes sense to define list of exceptions where not cookies are accepted. What exceptions do you want to define when cookies aren't accepted generally? What am I missing?

EDIT: Ah, I see it now, this is bad UI, but the exceptions panel says "always" or "never", so if you generally don't accept cookies, you can add some "always" exceptions.

Summary: Cookies Exception button greyed out → When the box 'Accept cookies from sites' is not checked, the cookies 'Exceptions' button is greyed out

Lasana, can you investigate+fix this.

Assignee: nobody → lasana
Flags: needinfo?(geoff)
Keywords: regressionwindow-wanted
Status: NEW → ASSIGNED
Attached patch bug1659335-fix.patch (obsolete) (deleted) — — Splinter Review

Fix and modified tests to check for this.

Attachment #9171770 - Flags: review?(mkmelin+mozilla)

You may need to fix the enterprise policy tests too.

Regressed by: 1622703
Attachment #9171770 - Flags: review?(mkmelin+mozilla)
Attached patch bug1659335-fixv2.patch (obsolete) (deleted) — — Splinter Review

I updated the browser_policy_cookie_settings tests as well.

Attachment #9171770 - Attachment is obsolete: true
Attachment #9171975 - Flags: review?(mkmelin+mozilla)
Attachment #9171975 - Flags: feedback?(geoff)
Comment on attachment 9171975 [details] [diff] [review] bug1659335-fixv2.patch Review of attachment 9171975 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/preferences/test/browser/head.js @@ +191,5 @@ > for (let test of tests) { > info(`Checking ${test.checkboxID}`); > > + let unaffectedSelectors = test.unaffectedElements || []; > + let unaffectedStates = unaffectedSelectors.map(getDisableState); would just inline this to .map(sel => prefsDocument.querySelector(sel).disabled);
Attachment #9171975 - Flags: review?(mkmelin+mozilla)
Attachment #9171975 - Flags: review+
Attachment #9171975 - Flags: feedback?(geoff)
Keywords: checkin-needed-tb
Target Milestone: --- → 82 Branch

Please update for comment 10 first

Keywords: checkin-needed-tb
Attachment #9171975 - Attachment is obsolete: true
Attached patch bug1659335fixv3.patch (deleted) — — Splinter Review

getDisableState replaced with arrow function.

Attachment #9172663 - Flags: review?(mkmelin+mozilla)
Attachment #9172663 - Flags: review?(mkmelin+mozilla) → review+
status-thunderbird81: --- → affected
status-thunderbird_esr78: --- → affected
Keywords: checkin-needed-tb
OS: Linux → All
Hardware: x86_64 → All

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d44db91db09e
Do not disable the cookie exceptions button when accept cookies is unchecked. r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Please request uplifts to beta and 78.

tracking-thunderbird_esr78: --- → +

Comment on attachment 9172663 [details] [diff] [review]
bug1659335fixv3.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1622703
User impact if declined: can't as easily add cookie exceptions

Attachment #9172663 - Flags: approval-comm-esr78?

Comment on attachment 9172663 [details] [diff] [review]
bug1659335fixv3.patch

[Triage Comment]
Approved for esr78

Attachment #9172663 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: