Closed Bug 1659390 Opened 4 years ago Closed 4 years ago

UI glitch in the alarm panel: Number box missing padding

Categories

(Calendar :: General, defect)

Product:
Calendar
Component:
General
Type:
defect

Tracking

(thunderbird_esr78 fixed, thunderbird80 fixed)

Status:
VERIFIED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed
thunderbird80 --- fixed

People

(Reporter: jorgk-bmo, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(3 files)

2020-08-17 09_04_33-Window.png
(deleted), image/png
Details
number-box.png
(deleted), image/png
Details
1659390-alarm-dialog-input-number.patch
(deleted), patch
pmorris
: review+
wsmwk
: approval-comm-beta+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review
Attached image 2020-08-17 09_04_33-Window.png (deleted) —

See enclosed screenshots.

There are bug 1656693 and bug 1659380 which are also about event, but about something else. I'm mentioning it here due to the "highlight" in the bug summary.

Flags: needinfo?(richard.musil)
Attached image number-box.png (deleted) —

Oops, sorry, wrong Richard.

Flags: needinfo?(richard.musil) → needinfo?(richard.marti)

The link colour is bug 1658923.

Flags: needinfo?(richard.marti)
Summary: Two UI glitches in the alarm panel: Number box missing padding and link not visible → UI glitche in the alarm panel: Number box missing padding
Summary: UI glitche in the alarm panel: Number box missing padding → UI glitch in the alarm panel: Number box missing padding

Needed to add the input-fields.css which adds the margin.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9170365 - Flags: review?(paul)
Comment on attachment 9170365 [details] [diff] [review] 1659390-alarm-dialog-input-number.patch Review of attachment 9170365 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #9170365 - Flags: review?(paul) → review+
Keywords: checkin-needed-tb
Target Milestone: --- → 81 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e4703ccbf8d7
Import input-fields.css to the alarm dialog to style the number input boxes correctly. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9170365 [details] [diff] [review]
1659390-alarm-dialog-input-number.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1657607
User impact if declined: value too near to the spin buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9170365 - Flags: approval-comm-esr78?
Attachment #9170365 - Flags: approval-comm-beta?

Comment on attachment 9170365 [details] [diff] [review]
1659390-alarm-dialog-input-number.patch

[Triage Comment]
Approved for beta
Approved for esr78

Attachment #9170365 - Flags: approval-comm-esr78?
Attachment #9170365 - Flags: approval-comm-esr78+
Attachment #9170365 - Flags: approval-comm-beta?
Attachment #9170365 - Flags: approval-comm-beta+

Just a friendly remark. Next time, you put someone else's address on CC by mistake, it would be great to remove it as well.

My apologies! Didn't occur to me. But yes, the mistaken NI added a CC and all the mail got dumped into your inbox.

Fixed in my test of 80.0b5 release candidate on Ubuntu 18.04.5 LTS

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: