Closed
Bug 1659410
Opened 4 years ago
Closed 4 years ago
Resolve with the class used to define the Custom Element
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Tracking
()
RESOLVED
FIXED
83 Branch
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: andrea.giammarchi, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0
Steps to reproduce:
- define a custom element
- analyze
whenDefined
resolved callback - find nothing passed along the resolved callback
Actual results:
whenDefined
resolves with undefined.
Expected results:
Accordingly with https://github.com/whatwg/html/issues/5552, whenDefined
should resolve with the class used to define the custom element in the registry.
Updated•4 years ago
|
Component: Untriaged → DOM: Core & HTML
Product: Firefox → Core
Assignee | ||
Comment 1•4 years ago
|
||
This is a feature request, right? Are there WPT tests / spec text for this?
This should be very easy to implement:
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
This passes the tests added in
https://github.com/web-platform-tests/wpt/pull/25033.
Updated•4 years ago
|
Assignee: nobody → emilio
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
James, do you know why bug 1659403 hasn't been closed even though the tests have been synced for a while?
Flags: needinfo?(james)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bb7ed8a23d0
Resolve whenDefined promises with custom element constructor. r=edgar
Comment 6•4 years ago
|
||
That was one of the syncs where we dropped some PRs I think, and the cleanup didn't close the bugs. I can look at that.
Flags: needinfo?(james)
Comment 7•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•