Open Bug 1659479 Opened 4 years ago Updated 3 years ago

[PI-713] The Picture-in-Picture button is not displayed after changing from "Default" to "Theater" view while the video is hovered

Categories

(Toolkit :: Picture-in-Picture, defect, P3)

Product:
Toolkit
Component:
Picture-in-Picture
Platform:
Desktop
All
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox80 --- affected

People

(Reporter: cfat, Unassigned)

References

(Blocks 1 open bug)

Details

[Affected versions]:

  • Firefox Beta 80.0b8, Build ID 20200813191622

[Affected platforms]:

  • Windows 10 x64
  • macOS 10.15
  • Ubuntu 16.04 x64

[Prerequisites]:

  • Have the latest Firefox Beta 80.0b8 installed.
  • Have the following prefs set:
    -> media.videocontrols.picture-in-picture.video-toggle.mode to 1
    -> media.videocontrols.picture-in-picture.video-toggle.position to right

[Steps to reproduce]:

  1. Open the browser with the profle from prerequisites.
  2. Navigate to Youtube and open a video.
  3. Click the "Theater mode" button.
  4. Don't move the cursor (or keep hovering the video).
  5. Move the cursor over the video and observe the behavior.

[Expected result]:

  • The Picture-in-Picture button is displayed on the right side of the video.

[Actual result]:

  • The Picture-in-Picture button is not displayed on the right side of the video.

[Notes]:

  • This issue is reproducible on all the branches of the experiment.
  • The cursor changes from arrow to hand pointing when hovering the area where the PiP button should be. If clicking that area, the PiP overlay is displayed.
  • The PiP button is displayed again if the cursor will stop hovering the video and then moved back on top of the video again.
  • Attached a screen recording of the issue here.

Thanks for the report. Mark suspects the issue is somewhere in this code:
https://searchfox.org/mozilla-central/rev/fa7f47027917a186fb2052dee104cd06c21dd76f/toolkit/actors/PictureInPictureChild.jsm#720

It seems this is not a regression with our experiment, as I can reproduce in Nightly on Mac without touching the prefs. I don't believe this needs to be fixed for the experiment, as hovering off the video and back on brings the PiP button back.

Priority: -- → P3

I can also reproduce this issue for fullscreen and miniplayer on Linux Mint 19.2. I can also reproduce it for miniplayer, but not fullscreen, on Windows 10. The cursor needs to be in the same area where PiP will be opened when triggering miniplayer for the issue to be observable in that case.
Tested on Firefox RC 80 (Build ID 20200817172600).
Attached is a recording for fullscreen and miniplayer.

Blocks: videopip
No longer blocks: 1651414
Component: Video/Audio Controls → Picture-in-Picture
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.