Stop using pipenv to manage |mach python-test|
Categories
(Testing :: Python Test, task, P3)
Tracking
(firefox-esr78 fixed, firefox82 fixed)
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr78+
|
Details |
|
Assignee | |
Comment 1•4 years ago
|
||
Pipenv is heavy weight and overkill for the purposes it is being used. We'd
like to remove it from the tree and |mach python-test| was one of the last
remanining use cases.
Rather than re-implementing the ability to specify a Python version via the
'--python' flag, this simply runs |mach python-test| with whatever Python
mach is running with.
This means that |mach python-test| will now use Python 3 by default. If
py2 tests are needed, then |python2 mach python-test| can be used instead.
|
||
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
Comment on attachment 9172185 [details]
Bug 1659539 - [python-test] Remove '--python' and stop using pipenv to manage virtualenvs
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to uplift https://phabricator.services.mozilla.com/D92173.
Otherwise, there's "sitecustomize" errors (and potentially other problems) because pipenv doesn't play nice with the new virtualenv version. - User impact if declined: None
- Fix Landed on Version: 82
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's a build-only patch
- String or UUID changes made by this patch:
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9172185 [details]
Bug 1659539 - [python-test] Remove '--python' and stop using pipenv to manage virtualenvs
Needed to better support running mach on newer macOS releases. Approved for 78.8esr.
|
|
||
Comment 6•4 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 7•4 years ago
|
||
| bugherder uplift | ||
Description
•