Closed Bug 1659550 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25051 - WebCodecs: Parse and validate decoder config codec strings

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25051 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25051
Details from upstream follow.

Chris Cunningham <chcunningham@chromium.org> wrote:

WebCodecs: Parse and validate decoder config codec strings

Updates Audio/Video Decoder to reject invalid codecs passed to
configure(). A TypeError should be thrown.

Adds wpt test to verify the behavior.

Bug:1113824
Change-Id: I647c476fa32e684d57816222e1787aeb8f723c25
Reviewed-on: https://chromium-review.googlesource.com/2360312
WPT-Export-Revision: 82a594054b3bfe8e4d0fec25c3c80a50554c81e4

PR 25051 applied with additional changes from upstream: 5d19229558e94c90c23b05df9260836e093df1b2
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 2 subtests

Status Summary

Firefox

TIMEOUT: 8
ERROR : 3

Chrome

TIMEOUT: 8
ERROR : 3

Safari

TIMEOUT: 8
ERROR : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/video-encoder.html: ERROR (Chrome: ERROR, Safari: ERROR)
Test VideoEncoder.configure(): TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Test VideoEncoder construction: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Test successful configure(), encode(), and flush(): TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Test encode() before configure() throws InvalidStateError.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/webcodecs/audio-decoder.html: ERROR (Chrome: ERROR, Safari: ERROR)
Test AudioDecoder.configure() codec validity: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Test AudioDecoder construction: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/webcodecs/video-decoder.html: ERROR (Chrome: ERROR, Safari: ERROR)
Test VideoDecoder construction: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Test VideoDecoder.configure() codec validity: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e2820b35def [wpt PR 25051] - WebCodecs: Evaluate decoder config codec strings, a=testonly https://hg.mozilla.org/integration/autoland/rev/267b01dcfbf2 [wpt PR 25051] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7e2820b35def
https://hg.mozilla.org/mozilla-central/rev/267b01dcfbf2

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.