Closed Bug 1659582 Opened 4 years ago Closed 2 years ago

Thunderbird is slow to start up with ical.js enabled and a reasonable sized calendar

Categories

(Calendar :: ICAL.js Integration, defect, P2)

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: standard8, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Using the latest nightly, and starting up Thunderbird with my work calendar, I'm seeing that it is much slower with ical.js enabled.

With the patch from bug 1659558 applied, I'm seeing ~20s with ical.js, and ~10s with libical.

Here's a profile from the latest Daily build: https://share.firefox.dev/34awksS

From the flame graph, there does appear to be quite a lot of time spend in various ical time related functions - nativeTime being an obvious one.

The nativeTime ones seem to look like they are spending quite a bit of time looking up properties or maybe accessing them.

It might also be worth getting a fresh profile once bug 1659558 has landed. I tried locally and the nativeTime appearances went away, but I also had lots of undefined symbols, so I wonder if there's actual improvements or if things are just getting lost.

Keywords: perf
Priority: -- → P2

(In reply to Mark Banner (:standard8) from comment #0)

It might also be worth getting a fresh profile once bug 1659558 has landed. I tried locally and the nativeTime appearances went away, but I also had lots of undefined symbols, so I wonder if there's actual improvements or if things are just getting lost.

bug 1659558 is done

Severity: -- → S2

(In reply to Mark Banner (:standard8) from comment #0)

Using the latest nightly, and starting up Thunderbird with my work calendar, I'm seeing that it is much slower with ical.js enabled.

With the patch from bug 1659558 applied, I'm seeing ~20s with ical.js, and ~10s with libical.

Here's a profile from the latest Daily build: https://share.firefox.dev/34awksS

From the flame graph, there does appear to be quite a lot of time spend in various ical time related functions - nativeTime being an obvious one. The nativeTime ones seem to look like they are spending quite a bit of time looking up properties or maybe accessing them.

TZ related, ala bug 978571 ? (I don't see much TZ in the profile)

(In reply to Wayne Mery (:wsmwk) from comment #1)

(In reply to Mark Banner (:standard8) from comment #0)

It might also be worth getting a fresh profile once bug 1659558 has landed. I tried locally and the nativeTime appearances went away, but I also had lots of undefined symbols, so I wonder if there's actual improvements or if things are just getting lost.

bug 1659558 is done

Done only in 82 branch and above from my understanding, correct?

Is this still slow, Mark?

Flags: needinfo?(standard8)

This all seems fine now, both with ical.js enabled and disabled.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(standard8)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.