STR

1. Enable the new tab modal print UI via print.tab_modal.enabled.
2. Print any page. From the new print UI, select "Save as PDF."
3. Click "Print using system dialog."

Actual

The file chooser for saving the PDF opens.

Expected

Given the name of the link, I would expect to still be able to open the system dialog and select a printer, change settings, etc. If my default or last used printer was "Save to PDF" and then I go straight to "Print using system dialog" this feels like unexpected behavior.

We had discussed disabling this button if "Save to pdf" is the chosen printer. However, it does look like other browsers keep it as an available option.

If we decide on disabling, I can get a different patch up.

So, is this RESOLVED INVALID, or are we going to try to morph it into a different fix?

Emma, patch failed to land.
Details:
We're sorry, Lando could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg import --no-commit -s 95 /tmp/tmpz08xtuoe: applying /tmp/tmpz08xtuoe

patching file toolkit/components/printing/content/print.js
Hunk #1 FAILED at 5
1 out of 2 hunks FAILED -- saving rejects to file toolkit/components/printing/content/print.js.rej
abort: patch failed to apply

https://hg.mozilla.org/mozilla-central/rev/9e46a64e1a7a

Reminder to request beta approval. (I know you're likely to revert this for a different approach, but uplifting this in the meantime should help avoid conflicts for other patches that need to be uplifted.)

Comment on attachment 9171734 [details]
Bug 1659626, hide option to open system dialog if 'save to pdf' is selected printer except on macosx

Beta/Release Uplift Approval Request

• User impact if declined: The user will be able to open the system dialog when "save to pdf" is the selected printer, despite windows/linux not having Save to pdf functionality in their native print dialog.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open firefox on windows or linux

2. Select "save to pdf" as printer
3. Notice "open with system dialog" link disappear

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No strings
• String changes made/needed: n/a

This is verified fixed using Firefox 82.0a1 (BuildId:20200827212940) on Windows 10 64bit & Ubuntu 18.04 (also confirming that the option is still displayed on macOS 10.14).

Leaving a ni? on myself and the qe-verify+ flag until this gets uplifted and verified in Beta as well.

Comment on attachment 9171734 [details]
Bug 1659626, hide option to open system dialog if 'save to pdf' is selected printer except on macosx

Approved for 81.0b4.

https://hg.mozilla.org/releases/mozilla-beta/rev/38a2fecc2ba1

This issue is verified fixed using Firefox 81.0b4 (BuildId:20200829200810) on Windows 10 64bit, macOS 10.14 & Ubuntu 20.04.