Consider adding an nsIPrinter.systemName
Categories
(Core :: Printing: Setup, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: jwatt, Assigned: alaskanemily)
References
(Blocks 1 open bug)
Details
(Keywords: perf, Whiteboard: [print2020_v82][old-ui-])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
nsPrinterListCUPS::NamedPrinter (added in bug 1658300) requires getting CUPS to iterate over all the printers which kinda defeats the purpose of nsIPrinterList::getNamedOrDefaultPrinter. Longer term we should consider exposing the CUPS "system" name for the frontend code to save to prefs for a given printer, and pass that to nsIPrinterList::getNamedOrDefaultPrinter.
|
Reporter | |
Comment 1•4 years ago
|
||
Putting this on the v82 list purely to consider this as part of trying to figure out what we can do about our bad perf issues.
|
|
Reporter | |
Updated•4 years ago
|
|
Assignee | |
Comment 2•4 years ago
|
||
I agree with this, it would make things simpler on OS X in particular if the frontend used the CUPS/Unix name for the printer, and then just used the display name/readable name for the UI.
I have my doubts it would too drastically affect performance, but we are definitely doing extra work we don't need to given how it's working right now.
The downside is that all current saved printers are using a readable name still. I suppose we could start by assuming the name is a Unix/CUPS name, and then fall back to checking readable names if that fails. That would hopefully make the common case simpler, and wouldn't add too much extra work to the worst case.
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 5•4 years ago
|
||
This is cheaper to lookup on platforms that use CUPS and do not show the Unix
name for printers. This only applies to OS X at the present.
|
||
Updated•4 years ago
|
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Description
•