Closed Bug 1659897 Opened 4 years ago Closed 4 years ago

Find in Page fail after Bug 1654270

Categories

(Core :: Find Backend, defect)

defect

Tracking

()

VERIFIED FIXED
82 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- wontfix
firefox81 + verified
firefox82 --- verified

People

(Reporter: rontilby, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Login to FamilySearch.org (Accounts are free)
load this url:
https://www.familysearch.org/tree/person/sources/KWZ3-J32
press <ctrl>F to find-in-page
In the search field type: seal

Actual results:

The text in the search field turns red indicating that the search text does not occur on the page.

Expected results:

The viewport should jump to the location of the search string and color the text green.

Note that searching for: "eal" or "temple sealing" is successful.

A mozregression session showed that this problem started with the fix for bug 1654270.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Find Toolbar
Product: Firefox → Toolkit
Component: Find Toolbar → Find Backend
Keywords: regression
Product: Toolkit → Core
Regressed by: 1654270
Has Regression Range: --- → yes

Huh, interesting edge case, thanks for filing!

Assignee: nobody → emilio
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached file Reduced test-case (deleted) —

Set release status flags based on info from the regressing bug 1654270

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d8222cd72dc Rewind if needed when hitting a forced break in find-in-page. r=jfkthame
Flags: needinfo?(emilio)

[Tracking Requested - why for this release]: Annoying find-in-page regression that other users have found too.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd7fb8f29da2 Rewind if needed when hitting a forced break in find-in-page. r=jfkthame
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Comment on attachment 9170919 [details]
Bug 1659897 - Rewind if needed when hitting a forced break in find-in-page. r=jfkthame

Beta/Release Uplift Approval Request

  • User impact if declined: Somewhat odd find-in-page failures.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: see test-case attached to the bug, also comment 0.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Relatively small change to find-in-page code, which is well covered by tests generally.
  • String changes made/needed: none
Flags: needinfo?(emilio)
Attachment #9170919 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9170919 [details]
Bug 1659897 - Rewind if needed when hitting a forced break in find-in-page. r=jfkthame

Approved for 81.0b5.

Attachment #9170919 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Confirmed as verified fixed on latest Nightly 82.0a1 (20200831215215) on Windows 10 x64bit and MacOS 10.14.6.

Also confirmed as verified fixed on latest Beta 81.0b5 (20200901203141) on Windows 10 x64bit and MacOS 10.14.6.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Regressions: 1704167
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: