Find in Page fail after Bug 1654270
Categories
(Core :: Find Backend, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox79 | --- | unaffected |
firefox80 | --- | wontfix |
firefox81 | + | verified |
firefox82 | --- | verified |
People
(Reporter: rontilby, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0
Steps to reproduce:
Login to FamilySearch.org (Accounts are free)
load this url:
https://www.familysearch.org/tree/person/sources/KWZ3-J32
press <ctrl>F to find-in-page
In the search field type: seal
Actual results:
The text in the search field turns red indicating that the search text does not occur on the page.
Expected results:
The viewport should jump to the location of the search string and color the text green.
Note that searching for: "eal" or "temple sealing" is successful.
A mozregression session showed that this problem started with the fix for bug 1654270.
Comment 1•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Huh, interesting edge case, thanks for filing!
Assignee | ||
Comment 3•4 years ago
|
||
Comment 4•4 years ago
|
||
Set release status flags based on info from the regressing bug 1654270
Assignee | ||
Comment 5•4 years ago
|
||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Backed out for perma failures.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313583154&repo=autoland&lineNumber=3632
Backout: https://hg.mozilla.org/integration/autoland/rev/694e4acf76559200c88b27a474f7d8782c455a04
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
|
||
[Tracking Requested - why for this release]: Annoying find-in-page regression that other users have found too.
Updated•4 years ago
|
Comment 10•4 years ago
|
||
bugherder |
Comment 11•4 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 12•4 years ago
|
||
Comment on attachment 9170919 [details]
Bug 1659897 - Rewind if needed when hitting a forced break in find-in-page. r=jfkthame
Beta/Release Uplift Approval Request
- User impact if declined: Somewhat odd find-in-page failures.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: see test-case attached to the bug, also comment 0.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Relatively small change to find-in-page code, which is well covered by tests generally.
- String changes made/needed: none
Assignee | ||
Updated•4 years ago
|
Comment 13•4 years ago
|
||
Comment on attachment 9170919 [details]
Bug 1659897 - Rewind if needed when hitting a forced break in find-in-page. r=jfkthame
Approved for 81.0b5.
Comment 14•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Comment 15•4 years ago
|
||
Confirmed as verified fixed on latest Nightly 82.0a1 (20200831215215) on Windows 10 x64bit and MacOS 10.14.6.
Comment 16•4 years ago
|
||
Also confirmed as verified fixed on latest Beta 81.0b5 (20200901203141) on Windows 10 x64bit and MacOS 10.14.6.
Description
•