Debugger is missing sources with fission enabled and remote frames
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(Fission Milestone:MVP, firefox83 fixed)
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: jdescottes, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(3 files)
STRs:
- enable fission
- start firefox
- go to https://bug1659969-root.glitch.me/
- open Debugger
ER:
Debugger should show sources from the parent page and from the remote frames
AR:
Debugger only shows sources for the remote frame
|
Reporter | |
Comment 1•4 years ago
|
||
|
|
Reporter | |
Comment 2•4 years ago
|
||
Added a mochitest that currently fails with fission because it shows one interesting thing: all sources are correctly in the state, but the source tree only shows the remote one.
|
|
Reporter | |
Comment 3•4 years ago
|
||
I tried to bisect a bit, but I am not sure we ever supported fission frames for the debugger in the content toolbox.
In older revisions, instead of seeing only the frame sources, we see the root sources. I am not sure when this changed to show only frame sources, but it never worked perfectly it seems.
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
I can simply reproduce the issue on my machine. Thanks Julian for the test case.
I see both sources when Fission is disabled.
Honza
|
|
||
Comment 5•4 years ago
|
||
We should retest as soon as bug 1620280 lands. There is a chance this could be fixed.
|
||
Comment 6•4 years ago
|
||
Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.
|
|
||
Comment 7•4 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #5)
We should retest as soon as bug 1620280 lands. There is a chance this could be fixed.
I can still reproduce the reported issue.
|
Assignee | |
Comment 8•4 years ago
|
||
(In reply to Julian Descottes [:jdescottes] from comment #3)
I tried to bisect a bit, but I am not sure we ever supported fission frames for the debugger in the content toolbox.
In older revisions, instead of seeing only the frame sources, we see the root sources. I am not sure when this changed to show only frame sources, but it never worked perfectly it seems.
+1, additional frame targets were all considered "main thread type":
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/client/firefox/create.js#101-111
and so later on in the reducer:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers/threads.js#95
returned an empty list of additional targets.
It is probably time for the debugger to use regular target object instead of wrapping it to yet another different type of objects with different attributes.
|
|
Assignee | |
Comment 9•4 years ago
|
||
|
|
Assignee | |
Comment 10•4 years ago
|
||
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 11•4 years ago
|
||
|
||
Comment 12•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d30d1bcf966c
https://hg.mozilla.org/mozilla-central/rev/ae2c48cf3d57
https://hg.mozilla.org/mozilla-central/rev/f685f13226cd
|
|
||
Updated•3 years ago
|
Description
•