Closed Bug 1660231 Opened 4 years ago Closed 4 years ago

Enable MASTER_PASSWORD_ENABLED probe on release

Categories

(Toolkit :: Password Manager, task, P2)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: RT, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

This probe is on pre-release only. Assessing share of DAU/MAUusing the feature will help understand:

  • Criticality of bringing improvements to the feature
  • Criticality of addressing scenarios where users share their desktop with other iusers (i.e improve profile management to make it user friendly)
Attached file data review form (obsolete) (deleted) —

Hi Chris, can you please help with a data review?

Attachment #9171193 - Flags: data-review?(chutten)
Blocks: 1630592
Severity: -- → N/A
Type: defect → task
Component: about:logins → Password Manager
Priority: -- → P2
Product: Firefox → Toolkit
Attachment #9171193 - Attachment description: datareviewform → data review form
Attachment #9171193 - Attachment mime type: application/octet-stream → text/plain

Comment on attachment 9171193 [details]
data review form

The request says "monitor this data for 6 months" but the stated probe does not expire. Please identify a person responsible for monitoring this permanent data collection.

Attachment #9171193 - Flags: data-review?(chutten)
Attached file datareviewform (deleted) —

New data review form requesting the probe to not expire and setting myself as responsible for monitoring the probe permanent collection

Attachment #9171193 - Attachment is obsolete: true

Comment on attachment 9173552 [details]
datareviewform

Re requesting review now that I addressed the comments

Attachment #9173552 - Flags: data-review?(chutten)
Attachment #9173552 - Attachment mime type: application/octet-stream → text/plain

Comment on attachment 9173552 [details]
datareviewform

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Romain Testard is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.


Result: datareview+

Attachment #9173552 - Flags: data-review?(chutten) → data-review+

Looks like this is ready to go, and just needs a patch.
My suspicion is there is a large overlap between people that enable primary password and people that disable telemetry, for what that is worth. But I see no reason not to turn this on on release and at least find out more.

Flags: needinfo?(sfoster)
Assignee: nobody → sfoster
Status: NEW → ASSIGNED

Patch attached. I didn't update the description to use "primary password" but maybe that is a change that can be done at the same time.

Flags: needinfo?(sfoster)
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0afb41084c0 Convert MASTER_PASSWORD_ENABLED (Primary Password enabled) histogram to opt-out for the release channel. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: