Print selection is available and doesn’t work properly for a pdf document
Categories
(Core :: Printing: Output, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | unaffected |
| firefox79 | --- | unaffected |
| firefox80 | --- | unaffected |
| firefox81 | --- | verified |
| firefox82 | --- | verified |
People
(Reporter: emilghitta, Assigned: bobowen)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [print2020_v81] [old-ui+])
Attachments
(2 files)
|
(deleted),
image/gif
|
Details | |
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
pdfSelection.gif
Affected versions
- 81.0a1 (BuildId:20200821033746)
Affected platforms
- Windows 10 64bit
- macOS 10.14
- Ubuntu 18.04 64bit
Steps to reproduce
- Launch Firefox.
- Open a pdf file.
- Select a portion of text.
- Open the system modal.
- Click the “Selection” option from the page range.
- Print the file as pdf or to paper.
Expected result
- The selection is printed or the print “selection” option is not available for a pdf file.
Actual result
- If printing to paper no actual print job is started. If the selection is printed to pdf it will output a blank pdf document.
Regression Window
- This seems to be a regression:
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=09921685a632ade2b9da3e027f433c12902bccd3&tochange=ad5909461c4af7de17369693d7c75922dccb4d96
- Potential regressor: Bug 1653334
Additional Information
- For further information regarding this issue please observe the attached screencast.
- This seems to affect both the new and old ui
- [Suggested Severity] S3
|
Reporter | |
Comment 1•4 years ago
|
||
Hi Bob!
It seems that mozregression pointed out Bug 1653334 part 2: Cache the selection ranges on subdocuments as we build the nsPrintObject tree. r=jwatt for causing this regression.
Can you please take a look?
Thank you!
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 2•4 years ago
|
||
I'll take a look at this.
|
|
Assignee | |
Comment 3•4 years ago
|
||
The problem is that I didn't allow for mDisallowSelectionPrint in my change, patch on the way.
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
|
||
Comment 7•4 years ago
|
||
Comment on attachment 9171694 [details]
Bug 1660463: Only allow printing of a selection when mDisallowSelectionPrint is false. r=jwatt!
Beta/Release Uplift Approval Request
- User impact if declined: Printing PDFs makes "print selection" an available option, but we don't support that for PDFs. This is a regression for the old UI as well as a bug with the new print UI.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple flag check to trigger existing codepath to hide option in UI.
- String changes made/needed:
|
||
Updated•4 years ago
|
|
|
||
Comment 8•4 years ago
|
||
Comment on attachment 9171694 [details]
Bug 1660463: Only allow printing of a selection when mDisallowSelectionPrint is false. r=jwatt!
Approved for 81.0b2.
|
|
||
Comment 9•4 years ago
|
||
| bugherder uplift | ||
|
|
Reporter | |
Comment 10•4 years ago
|
||
This is verified fixed using Firefox 82.0a1 (BuildId:20200827212940) and Firefox 81.0b3 (BuildId:20200827203325) on Windows 10 64bit, macOS 10.14 & Ubuntu 18.04 64bit.
|
||
Comment 11•4 years ago
|
||
Description
•