Closed
Bug 1660983
Opened 4 years ago
Closed 4 years ago
Warp: some AddSlot optimizations
Categories
(Core :: JavaScript Engine: JIT, task, P2)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
82 Branch
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
- We can get rid of the group guard if TI is disabled.
- The "add function .prototype" optimization depends on interpreted-function ObjectGroups and no longer works without TI. This was a pretty significant win because it avoids an object allocation (bug 1336579 comment 3) so we should fix that to not depend on TI.
Assignee | ||
Comment 1•4 years ago
|
||
holderId was used for unboxed object expando properties.
Assignee | ||
Comment 2•4 years ago
|
||
This makes the optimization work with Warp.
Also stop emitting GuardGroup if TI is disabled.
Depends on D88129
Assignee | ||
Comment 3•4 years ago
|
||
Just a drive-by change for something I noticed.
Depends on D88130
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b3331ff39f4
part 1 - Remove unnecessary holderId variable in tryAttachAddSlotStub. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/f9d5521819eb
part 2 - Make the function.prototype AddSlot optimization not depend on TI. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/6a146cf8deb2
part 3 - Don't turn prototypes into singletons if TI is disabled. r=evilpie
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b3331ff39f4
https://hg.mozilla.org/mozilla-central/rev/f9d5521819eb
https://hg.mozilla.org/mozilla-central/rev/6a146cf8deb2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•