Closed
Bug 1661598
Opened 4 years ago
Closed 4 years ago
Add search engine dialog allows duplicate alias
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1664566
Iteration:
82.1 - Aug 24 - Sep 6
People
(Reporter: mathew.hodson, Assigned: daleharvey)
References
Details
Attachments
(1 obsolete file)
Steps to reproduce:
- Set browser.urlbar.update2.engineAliasRefresh = true to enable the new add search engine dialog from bug 1106626
- Go to about:preferences#search
- Click Add button under One-Click Search Engines
- Add an engine with any name and URL and the alias "test"
- Add a second engine with a different name but the same alias "test"
Actual results:
Search engine with a duplicate alias is added.
Expected results:
The Add Engine button should be disabled with a validation message "An engine with that alias already exists."
Reporter | ||
Comment 1•4 years ago
|
||
I think this was a copy and paste error at https://searchfox.org/mozilla-central/rev/ce21a13035623c1d349980057d09000e70669802/browser/components/preferences/dialogs/addEngine.js#56
Should be
validity = document.getElementById("engineAliasExists").textContent;
Assignee | ||
Comment 2•4 years ago
|
||
Yup, doing a last minute change before pushing is always a bad idea
Assignee: nobody → dharvey
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Iteration: --- → 82.1 - Aug 24 - Sep 6
Points: --- → 1
Reporter | ||
Updated•4 years ago
|
Version: unspecified → Firefox 82
Comment 4•4 years ago
|
||
The severity field is not set for this bug.
:daleharvey, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(dharvey)
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(dharvey)
Assignee | ||
Comment 5•4 years ago
|
||
Fixed this in the dupe
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Updated•4 years ago
|
Attachment #9172607 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•