Closed Bug 1661598 Opened 4 years ago Closed 4 years ago

Add search engine dialog allows duplicate alias

Categories

(Firefox :: Search, defect)

Firefox 82
defect
Points:
1

Tracking

()

RESOLVED DUPLICATE of bug 1664566
Iteration:
82.1 - Aug 24 - Sep 6

People

(Reporter: mathew.hodson, Assigned: daleharvey)

References

Details

Attachments

(1 obsolete file)

Steps to reproduce:

  1. Set browser.urlbar.update2.engineAliasRefresh = true to enable the new add search engine dialog from bug 1106626
  2. Go to about:preferences#search
  3. Click Add button under One-Click Search Engines
  4. Add an engine with any name and URL and the alias "test"
  5. Add a second engine with a different name but the same alias "test"

Actual results:

Search engine with a duplicate alias is added.

Expected results:

The Add Engine button should be disabled with a validation message "An engine with that alias already exists."

I think this was a copy and paste error at https://searchfox.org/mozilla-central/rev/ce21a13035623c1d349980057d09000e70669802/browser/components/preferences/dialogs/addEngine.js#56

Should be
validity = document.getElementById("engineAliasExists").textContent;

Depends on: 1106626

Yup, doing a last minute change before pushing is always a bad idea

Assignee: nobody → dharvey
Iteration: --- → 82.1 - Aug 24 - Sep 6
Points: --- → 1
Version: unspecified → Firefox 82

The severity field is not set for this bug.
:daleharvey, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dharvey)
Flags: needinfo?(dharvey)

Fixed this in the dupe

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Attachment #9172607 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: