Closed
Bug 1661731
Opened 4 years ago
Closed 4 years ago
OpenPrinterW in nsPrinterWin::DefaultSettings is not working.
Categories
(Core :: Printing: Setup, defect, P1)
Tracking
()
RESOLVED
FIXED
82 Branch
People
(Reporter: bobowen, Assigned: bobowen)
References
Details
(Whiteboard: [print2020_v81] )
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
In noticed this while looking at something else, the way I used nsAutoPrinter in nsPrinterWin::DefaultSettings does not work.
It looks like DocumentPropertiesW might work anyway because we pass in the name, but we've not used it that way before.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d4806f9d1294
Fix use of nsAutoPrinter in nsPrinterWin::DefaultSettings. r=jwatt
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
|
Assignee | |
Comment 5•4 years ago
|
||
Comment on attachment 9172713 [details]
Bug 1661731: Fix use of nsAutoPrinter in nsPrinterWin::DefaultSettings. r=jwatt!
Beta/Release Uplift Approval Request
- User impact if declined: Potential issues with printing due to non-standard use of Windows printing APIs.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very simple fix to open the printer handle correctly for use in subsequent calls.
- String changes made/needed: None
Flags: needinfo?(bobowencode)
Attachment #9172713 -
Flags: approval-mozilla-beta?
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9172713 [details]
Bug 1661731: Fix use of nsAutoPrinter in nsPrinterWin::DefaultSettings. r=jwatt!
Approved for 81.0b4.
Attachment #9172713 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 7•4 years ago
|
||
| bugherder uplift | ||
status-firefox81:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•