Closed Bug 1661785 Opened 4 years ago Closed 4 years ago

Explicitly check for COLOR and AUTO color modes with CUPS

Categories

(Core :: Printing: Setup, defect, P1)

Product:
Core
Component:
Printing: Setup
Platform:
Unspecified
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed
firefox82 --- fixed

People

(Reporter: alaskanemily, Assigned: alaskanemily)

References

Details

(Whiteboard: [print2020_v81])

Attachments

(1 file)

Bug 1661785 - Check for both CUPS_PRINT_COLOR_MODE_COLOR and CUPS_PRINT_COLOR_MODE_AUTO for CUPS color printing support.
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details

This may fix bug 1660658. In any case, I don't see any special processing in cupsCheckDestSupported to consider CUPS_PRINT_COLOR_MODE_COLOR to be a subset of CUPS_PRINT_COLOR_MODE_AUTO, consider color to be supported if auto is supported.

This may fix bug 1660658. It's pretty harmless if it turns out to be redundant
to make this check.

Pushed by emcdonough@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35664ccb8c1b
Check for both CUPS_PRINT_COLOR_MODE_COLOR and CUPS_PRINT_COLOR_MODE_AUTO for CUPS color printing support. r=nordzilla

Reminder to myself to test this.

Flags: needinfo?(jwatt)

As of build 20200828153126:
There is no print preview option

Ubuntu 16.04- the print option does appear in color. The color/b&w selection item is greyed out with color mode "blank and white" selected. A print is in color, the about:config variable print.print_in_color remains TRUE

Ubuntu 18.04 - same as 16.04 except, the color/b&w selection item is operable.

https://hg.mozilla.org/mozilla-central/rev/35664ccb8c1b

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Reminder to request Beta uplift.

Flags: needinfo?(jwatt) → needinfo?(emcdonough)
Flags: needinfo?(jwatt)

Comment on attachment 9172761 [details]
Bug 1661785 - Check for both CUPS_PRINT_COLOR_MODE_COLOR and CUPS_PRINT_COLOR_MODE_AUTO for CUPS color printing support.

Beta/Release Uplift Approval Request

  • User impact if declined: Color print preview on non-Windows platforms might be unavailable for certain printers
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch is very self-contained, and all further print preview work is being tested with it already in place.
  • String changes made/needed:
Flags: needinfo?(emcdonough)
Attachment #9172761 - Flags: approval-mozilla-beta?

Comment on attachment 9172761 [details]
Bug 1661785 - Check for both CUPS_PRINT_COLOR_MODE_COLOR and CUPS_PRINT_COLOR_MODE_AUTO for CUPS color printing support.

Approved for 81.0b5.

Attachment #9172761 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Something just changed in Firefox nightly as of build 20200831215215. The problem I reported as bug 1660658 is back.

(In reply to Lee McFarland from comment #10)

Something just changed in Firefox nightly as of build 20200831215215. The problem I reported as bug 1660658 is back.

Conversation continued at bug 1660658 comment 24.

Flags: needinfo?(jwatt)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: