Crash @ arm_aes_encrypt_ecb_128 when building with clang 11
Categories
(NSS :: Libraries, defect)
Tracking
(firefox-esr68 unaffected, firefox-esr78 wontfix, firefox80 wontfix, firefox81 wontfix, firefox82 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | wontfix |
| firefox80 | --- | wontfix |
| firefox81 | --- | wontfix |
| firefox82 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
|
Assignee | |
Comment 1•4 years ago
|
||
Things worked fine before we upgraded to clang 11 presumably because the
stack was always 16-bytes aligned in the first place, or something akin
to that, and the lack of pre_align/post_align doing anything didn't
matter. The runtime misalignment of the stack may well be a clang > 9
bug, but keeping pre_align/post_align tied to the x86/x64 is a footgun
anyways.
|
|
Assignee | |
Comment 3•4 years ago
|
||
We'll need an NSS update in mozilla-central to pick this and unblock bug 1660340. How do we go about that? (Or can we just cherry-pick? Surely the next update should not lose the change, since it's now landed)
|
||
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
Just landed it on autoland, :glandium: https://hg.mozilla.org/integration/autoland/rev/f39bc2f76fe1
|
|
Assignee | |
Comment 5•4 years ago
|
||
Thank you.
|
|
||
Comment 6•4 years ago
|
||
|
||
Comment 7•4 years ago
|
||
I assume we're not worried about downstream distros trying to build <82 with clang11, but feel free to correct me if I'm wrong.
|
||
Updated•4 years ago
|
Description
•