The bookmarks.html from my Mozilla 1.1 profile is incompletely imported into Navigator. No error is returned. This is fairly recent, but I don't know when it started. Rearranging bookmarks changes the point of truncation. The bookmarks.html file displays correctly in the browser of both Moz and Nav. I'll attach the file. Running OS 10.2.

This is the file that is unsuccessfully imported by the latest nightlies of Chimera. As an aside, and what made me try to re-import in the first place, tab-group bookmarks created in Mozilla and present in this file are imported as folders of individual bookmarks, not as tab-group bookmarks.

wjtaggart@fuse.net, what build ID are you reporting this bug against?

sorry -- 2002090105 Chimera Nightly

Thanks; will take a look.

I figured out why this happens. The bookmarks.html file has a UTF-8 charset, which induces a reload of the file. However, we start parsing bookmarks on the first pass, rather than waiting for a successful load to complete. So the fix is to just check the 'succeeded' flag in onLoadingCompleted: Index: BrowserWrapper.mm =================================================================== RCS file: /cvsroot/mozilla/chimera/src/browser/BrowserWrapper.mm,v retrieving revision 1.30.2.3 diff -u -r1.30.2.3 BrowserWrapper.mm --- BrowserWrapper.mm 4 Sep 2002 17:50:15 -0000 1.30.2.3 +++ BrowserWrapper.mm 5 Sep 2002 01:12:28 -0000 @@ -301,7 +301,7 @@ mIsBusy = NO; - if (mIsBookmarksImport) { + if (succeeded && mIsBookmarksImport) { nsCOMPtr<nsIDOMWindow> domWindow; nsCOMPtr<nsIWebBrowser> webBrowser = getter_AddRefs([mBrowserView getWebBrowser]); webBrowser->GetContentDOMWindow(getter_AddRefs(domWindow));

Fix checked in.

wjtaggart, the URL is broken --could you pls update it, or attach the bookmarks file directly to this bug? thanks!

sorry -- I removed it after it had been reported as fixed. It's back out there.

okay, i was able to import the bookmarks.html file (thanks, wjtaggart!) ... i think there might be a problem with importing of group bookmarks, but i'll see if that's already been filed (or file a new bug if needed).

filed bug 170797 for the bm group being imported as a folder. vrfy'ing this one.