Affected versions

• 81.0b4, 82.0a1(2020-08-30)

Affected platforms

• Windows 10, macOS 10.15, Ubuntu 18;

Steps to reproduce

1. Launch Firefox;
2. Open any PDF file and save it locally;
3. Open the locally saved file;
4. Hover over the [Download] icon;

Expected/Enhancement suggestion

• tooltip to show [Save] message;

Actual result

• tooltip shows the [Download] message;

Regression range

• not a regression;

Additional notes

• S4 as suggested severity, since it's a suggestion;
• the reasoning would be to have the tooltip update since the file is already downloaded and saved on the machine.

Hey, I would like to work on this issue!

Brendan or Calixte can help you. You can also contact us in the PDF.js room on Matrix: https://chat.mozilla.org/#/room/#pdfjs:mozilla.org.

:janvi01, you need to get pdf.js and set up a dev environment for it:
https://github.com/mozilla/pdf.js/#getting-the-code
For this bug, you probably want to change the tooltip depending on the file url so you'd need to have a firefox dev environment too:
https://firefox-source-docs.mozilla.org/setup/linux_build.html
You can create the js files for firefox in using gulp mozcentral from your local pdfjs setup and in moving the generated files to https://searchfox.org/mozilla-central/source/toolkit/components/pdfjs.

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Romain, do you think we should differentiate the text depending on whether the file is open locally or not, or just always say "Save"?

Technically the file is always downloaded before the user hit's "Save" - my opinion is this should always be a "Save as..." action.
I pinged content design on https://mozilla-hub.atlassian.net/browse/FFCD-65 to get to a decision

(In reply to Romain Testard [:RT] from comment #7)

Technically the file is always downloaded before the user hit's "Save" - my opinion is this should always be a "Save as..." action.
I pinged content design on https://mozilla-hub.atlassian.net/browse/FFCD-65 to get to a decision

I agree with updating the string to “Save”.

Keeps it consistent with the other hover texts (e.g. “Draw,” “Text,” etc; Makes the action most apparent to the broadest range of users)