Range error (for invalid custom range) is displayed for “All” range as well
Categories
(Toolkit :: Printing, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox80 | --- | unaffected |
firefox81 | --- | verified |
firefox82 | --- | verified |
People
(Reporter: emilghitta, Assigned: emmamalysz)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [print2020_v81] [old-ui-])
Attachments
(2 files)
(deleted),
image/gif
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
Affected versions
- 82.0a1 (BuildId:20200901214943)
- 81.0b5 (BuildId:20200901203141)
Affected platforms
- Windows 10 64bit
- Ubuntu 18.04 64bit
- macOS 10.14
Steps to reproduce
- Launch Firefox.
- Access the following link.
- Select an invalid Custom page range.
- Switch to “all” page range fast.
Expected result
- The invalid page range error is not displayed for the “all” range even if the user has fastly changed from an invalid custom range to the “all” range.
Actual result
- The invalid page range error remains displayed even if the “all” range is selected.
Regression Window
- This seems to be a regression but I can't find the exact regressor using mozregression because it throws me some errors and quits the regression search. This is the furthest I can go -> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=432e42cbbc4139efd2319952ec33efe8ff9add3c&tochange=369f72130f3604c85f73a3b03b2b48f33ad9b19e
Additional Information
- For further information regarding this issue please observe the attached screencast.
- [Suggested Severity] S3 or S4
Reporter | ||
Updated•4 years ago
|
Comment 1•4 years ago
|
||
(Emma probably knows what the fix here is…)
Comment 2•4 years ago
|
||
(Also, I can't reproduce this on macOS on the Nightly I just installed (82.0a1 (2020-09-02)), and I know we're doing some work in this area, so it might have been fixed by something that just landed. Specifically bug 1662145 looks similar.)
Reporter | ||
Comment 3•4 years ago
|
||
Odd...I can reproduce this issue using Firefox 82.0a1 (BuildId:20200902095359) on macOS 10.14..the trick is to change from custom
to all
pretty fast.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9173664 [details]
Bug 1662691, ensure we clear the error timeout when switching to 'all' page range
Beta/Release Uplift Approval Request
- User impact if declined: The user may incorrectly see an error message
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1. Open firefox with
printing.tab_modal.enabled
turned on
- Command P
- Change the page range from custom to all
- enter an invalid number in the range
- In less than half a second (before the error shows), go from "custom" to "all"
- Notice the error does not appear
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): No strings
- String changes made/needed: n/a
Assignee | ||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
bugherder |
Reporter | ||
Comment 8•4 years ago
|
||
This issue is verified fixed using Firefox 82.0a1 (BuildId:20200903094553) on Windows 10 64bit, macOS 10.14 & Ubuntu 18.04 64bit.
Leaving a ni? on myself and the qe-verify+ until this gets verified in beta as well.
Comment 9•4 years ago
|
||
Comment on attachment 9173664 [details]
Bug 1662691, ensure we clear the error timeout when switching to 'all' page range
Approved for 81.0b6.
Comment 10•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Reporter | ||
Comment 11•4 years ago
|
||
This is verified fixed using Firefox 81.0b7 (BuildId:20200906164749) on Windows 10 64bit, macOS 10.14 & Ubuntu 18.04 64bit.
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Description
•