Closed
Bug 1662703
Opened 4 years ago
Closed 4 years ago
[css-ui] Change appearance: button to only apply to buttons
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: mozilla-apprentice, Assigned: emilio)
References
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
A resolution was made for csswg-drafts/#5174.
[css-ui] Change appearance: button to only apply to buttons
- RESOLVED: Limit 'appearance: button' to buttons once we figure out what buttons are
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Keywords: dev-doc-needed
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
The protections.css declaration is not needed, because you're setting
backgrounds and borders anyways so native appearance is disabled.
The button.css change needs to turn into a -moz-default-appearance +
appearance combo, but since it's in three different places, just put it
in xul.css instead.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56e1f7f0268b
Tweak appearance: button usage in browser/ and toolkit/. r=dao
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/baab244deeb0
Make appearance: button behave like auto. r=heycam
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
|
||
Comment 7•4 years ago
|
||
Backed out for perma failures.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315271846&repo=autoland&lineNumber=10340
Backout: https://hg.mozilla.org/integration/autoland/rev/012726c6a965af26b5890db11bc3ebf9ef441ccf
Flags: needinfo?(emilio)
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
|
Assignee | |
Updated•4 years ago
|
Status: RESOLVED → REOPENED
Flags: needinfo?(emilio)
Resolution: FIXED → ---
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a3863563468
Make appearance: button behave like auto. r=heycam
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25576 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
|
||
Updated•4 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
|
|
||
Comment 13•4 years ago
|
||
The BCD has already been merged for this, so I've just added a note in the 82 release notes.
You need to log in
before you can comment on or make changes to this bug.
Description
•