Closed Bug 1663003 Opened 4 years ago Closed 4 years ago

regression: Black border around shaped popups with MOZ_X11_EGL=1

Categories

(Core :: Graphics: WebRender, defect)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 --- unaffected
firefox82 --- fixed

People

(Reporter: jan, Assigned: stransky)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(4 files)

Gnome Xwayland, Debian Testing, Mesa 20.1.5, Intel HD Graphics 630 (KBL GT2)
MOZ_X11_EGL=1 mozregression --repo autoland --launch 20b1b9a1db08 --pref gfx.webrender.all:true

bug 1650583 made MOZ_X11_EGL+WebRender look like bug 1479135. It doesn't occur with GLX+WebRender or MOZ_X11_EGL+Basic.

Flags: needinfo?(stransky)
Summary: regression: Black border around shaped popups with MOZ_X11_EGL=1 → regression: Black border around shaped popups with MOZ_X11_EGL=1 on Xwayland

I'll look at it when the recent patches lands.
Thanks.

Flags: needinfo?(stransky)
Flags: needinfo?(stransky)

Also present on EGL/Gnome X11/proprietary Nvidia. (Debian Testing, Nvidia GTX 1060, driver 450.57)

Summary: regression: Black border around shaped popups with MOZ_X11_EGL=1 on Xwayland → regression: Black border around shaped popups with MOZ_X11_EGL=1
Assignee: nobody → stransky
Flags: needinfo?(stransky)

Also present with EGL with amdgpu, Mesa 20.1.7 on Arch Linux.

Attached image address bar.png (deleted) —

Also in fadded-out address bar.

Yes, I can reproduce that too. I expect it's some visual misconfiguration on EGL.

The problem is that we don't get visual with alpha on EGL for any window :)

Don't worry, I have a patch almost ready.

Yeah, seems to be more complicated than I expected which should not surprise me :)
EGL does not provide a way how to select a composited visual so we'd need to use GLX for that.
That does not work on nvidia binary drivers but they have poor support for EGL anyway so there's no point to use EGL on Nvidia right now.

Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3035ba4d8fc [Linux/EGL] When we can't find EGLConfig with actual XVisual, use the first suitable one, r=jgilbert https://hg.mozilla.org/integration/autoland/rev/50a87c4ddf15 [Linux/EGL] Use GLX to find X Visual for EGL as a workaround for https://gitlab.freedesktop.org/mesa/mesa/-/issues/149, r=jgilbert
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92159cd14d67 [Linux/EGL] When we can't find EGLConfig with actual XVisual, use the first suitable one, r=jgilbert https://hg.mozilla.org/integration/autoland/rev/5012e5d4c2d7 [Linux/EGL] Use GLX to find X Visual for EGL as a workaround for https://gitlab.freedesktop.org/mesa/mesa/-/issues/149, r=jgilbert
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: