[wpt-sync] Sync PR 25398 - regression fix: non-auto table sizing inside flexbox
Categories
(Core :: Layout: Flexbox, task, P4)
Tracking
()
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 25398 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/25398
Details from upstream follow.
b'Aleks Totic <atotic@chromium.org>' wrote:
regression fix: non-auto table sizing inside flexbox
https://chromium-review.googlesource.com/c/chromium/src/+/2214895
introduced a change where LayoutTable started respecting
OverrideLogicalWidth for flex items.This broke rendering of non-auto tables inside flexbox.
The fix has 2 parts:
- LayoutTable::UpdateLogicalWidth always respects OverrideLogicalWidth
- FlexLayoutAlgorithm::ShouldApplyMinSizeAutoForChild returns true
for tables.Another side effect of this fix is that the TablesNG flexbox hack
is no longer needed.
https://chromium-review.googlesource.com/c/chromium/src/+/1730138/167/third_party/blink/renderer/core/layout/ng/flex/ng_flex_layout_algorithm.ccBug: 1123100
Change-Id: Ide428db79a3d9b26e426c6f7727349549ea40836
Reviewed-on: https://chromium-review.googlesource.com/2392444
WPT-Export-Revision: 0b294b59825c2b67fa3e3b9e0eea8e525e7a66b4
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 2 subtests
Status Summary
Firefox
OK : 1
FAIL: 2
Chrome
OK : 1
FAIL: 2
Safari
OK : 1
FAIL: 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/css/css-flexbox/table-with-percent-intrinsic-width.html
table 1: FAIL (Chrome: FAIL, Safari: FAIL)
table 2: FAIL (Chrome: FAIL, Safari: FAIL)
Updated•4 years ago
|
Description
•