Remove MOZ_MUST_USE comment from NSIS BitsUtils.cpp
Categories
(Firefox :: Installer, task, P3)
Tracking
()
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The MOZ_MUST_USE
macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result))
. Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE
with C++17's standard [[nodiscard]]
attribute.
BitsUtils.cpp only references MOZ_MUST_USE
in a comment about forking a copy of mozilla::ScopeExit
to remove some dependencies on other Mozilla header files (including MOZ_MUST_USE
from mfbt/Attributes.h). [[nodiscard]]
doesn't require a header file, so we can just remove this comment about MOZ_MUST_USE
.
Assignee | ||
Comment 1•4 years ago
|
||
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
BitsUtils.cpp only references MOZ_MUST_USE in a comment about forking a copy of mozilla::ScopeExit to remove some dependencies on other Mozilla header files (including MOZ_MUST_USE from mfbt/Attributes.h). [[nodiscard]] doesn't require a header file, so we can just remove this comment about MOZ_MUST_USE.
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/326bcbd907df Remove MOZ_MUST_USE comment from NSIS BitsUtils.cpp. r=agashlin
Comment 3•4 years ago
|
||
bugherder |
Updated•1 year ago
|
Description
•