Closed
Bug 1663237
Opened 4 years ago
Closed 4 years ago
Replace MOZ_MUST_USE with [[nodiscard]] in mozjemalloc
Categories
(Core :: Memory Allocator, task, P3)
Core
Memory Allocator
Tracking
()
RESOLVED
FIXED
82 Branch
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The MOZ_MUST_USE
macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result))
. Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE
with C++17's standard [[nodiscard]]
attribute.
Assignee | ||
Comment 1•4 years ago
|
||
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
We can also stop #including mozilla/Attributes.h because it was only needed for its MOZ_MUST_USE declaration.
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f84c5f5a05a Replace MOZ_MUST_USE with [[nodiscard]] in mozjemalloc. r=glandium
Comment 3•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•